-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudMenu: Improve Encapsulation, public API is now Async #8634
Conversation
We also probably should just make IsOpen as two way bindable, because there is |
This tests are weird |
0718644
to
6a0777f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8634 +/- ##
==========================================
+ Coverage 89.82% 90.08% +0.25%
==========================================
Files 412 418 +6
Lines 11878 12006 +128
Branches 2364 2366 +2
==========================================
+ Hits 10670 10816 +146
+ Misses 681 658 -23
- Partials 527 532 +5 ☔ View full report in Codecov by Sentry. |
Added to v7.0.0 Migration Guide #8447 |
Description
Fixes encapsulation
I do not think that
MouseEnter
andMouseLeave
should be public.was changed to explicit
IActivatable
implementation as I also do not think this API should be visible.was removed, since
IActivatable
doesn't have such definition.I also do not understand why
PopoverStyle
is public?If it can be changed outside, then it should be declared as Blazor Parameter, if not and it's only used for internal styling, then it shouldn't be visible.
UriHelper
andJsApiService
were changed to protected, as it also shouldn't be used outside.OnClickHandler
renamed toOnClickHandlerAsync
ToggleMenu
,CloseMenu
,OpenMenu
are now async, since they callEventCallback
Summarize:
MouseEnter
,MouseLeave
are private now.Activate(object activator, MouseEventArgs args)
is explicit now.Activate(object activator, TouchEventArgs args)
removed.PopoverStyle
is private now.UriHelper
,JsApiService
changed from public to protected.OnClickHandler
->OnClickHandlerAsync
.ToggleMenu
,CloseMenu
,OpenMenu
are now async.How Has This Been Tested?
Types of changes
Checklist
dev
).