Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudBaseInput: Add nullable annotation. #8635

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

ScarletKuro
Copy link
Member

Description

Part of this issue #6535

How Has This Been Tested?

No tests required.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change, improve null diagnostic warnings)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.85%. Comparing base (28bc599) to head (2511635).
Report is 18 commits behind head on dev.

Files Patch % Lines
src/MudBlazor/Base/MudBaseInput.cs 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8635      +/-   ##
==========================================
+ Coverage   89.82%   89.85%   +0.02%     
==========================================
  Files         412      414       +2     
  Lines       11878    11913      +35     
  Branches     2364     2364              
==========================================
+ Hits        10670    10705      +35     
+ Misses        681      677       -4     
- Partials      527      531       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit d75dd57 into MudBlazor:dev Apr 10, 2024
3 of 4 checks passed
@ScarletKuro ScarletKuro deleted the MudBaseInput_nullable branch April 10, 2024 23:16
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant