Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert: Remove AlertTextPosition #8637

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

ScarletKuro
Copy link
Member

Description

After this PR #8532 it's not used anymore

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.

@ScarletKuro ScarletKuro requested a review from henon April 11, 2024 00:35
@ScarletKuro ScarletKuro added API change API that needs approval v7 New major MudBlazor version and removed PR: needs review labels Apr 11, 2024
@danielchalmers
Copy link
Contributor

danielchalmers commented Apr 11, 2024

Ha got there just before me 😀

I was going to check the whole codebase for unused code. Do you know if there's any more?

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (28bc599) to head (f4fab9c).
Report is 19 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8637      +/-   ##
==========================================
+ Coverage   89.82%   89.88%   +0.05%     
==========================================
  Files         412      414       +2     
  Lines       11878    11913      +35     
  Branches     2364     2364              
==========================================
+ Hits        10670    10708      +38     
+ Misses        681      675       -6     
- Partials      527      530       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member Author

Added to v7.0.0 Migration Guide #8447 under "Others"

@ScarletKuro ScarletKuro merged commit 6218eea into MudBlazor:dev Apr 12, 2024
5 checks passed
@ScarletKuro ScarletKuro deleted the AlertTextPosition_remove branch April 12, 2024 11:34
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change API that needs approval breaking change v7 New major MudBlazor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants