Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroup: Fix border rounding overflow on selected item #8652

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

If you enabled the Rounded property it would be fine, but the inherited border-radius from MudTheme would overflow. This fixes that and simplifies the implementation by hiding the overflow instead of calculating the rounding.

Also reverts a fourth toggle button in the example added in #8377 which made the whole thing too cramped when CheckMarks were enabled.

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Setting border radius in theme:

image

image

Using Rounded proeprty:

image

I was unable to remove the hairline artifact on the edges but I'll try again in the future. My goal today was making it look presentable.

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

If you enabled the Rounded property it would be fine, but the inherited border-radius from MudTheme would overflow. This fixes that and simplifies the implementation by hiding the overflow instead of calculating the rounding.

Also reverts a fourth toggle button in the example added in MudBlazor#8377 which made the whole thing too cramped when CheckMarks were enabled.
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (28bc599) to head (af77482).
Report is 27 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8652      +/-   ##
==========================================
+ Coverage   89.82%   90.02%   +0.19%     
==========================================
  Files         412      418       +6     
  Lines       11878    12025     +147     
  Branches     2364     2372       +8     
==========================================
+ Hits        10670    10825     +155     
+ Misses        681      666      -15     
- Partials      527      534       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 176b4e5 into MudBlazor:dev Apr 12, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 12, 2024

Thanks Daniel!

@danielchalmers danielchalmers deleted the togglegroup-borderradius branch April 12, 2024 18:35
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants