-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudTreeView: Add ripple effect (#8570) #8669
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8669 +/- ##
==========================================
+ Coverage 89.82% 90.06% +0.23%
==========================================
Files 412 418 +6
Lines 11878 12008 +130
Branches 2364 2366 +2
==========================================
+ Hits 10670 10815 +145
+ Misses 681 659 -22
- Partials 527 534 +7 ☔ View full report in Codecov by Sentry. |
You should probably include a |
0130dd4
to
1348c09
Compare
@Anu6is I've added the |
1348c09
to
83abe51
Compare
The "Expand on double click" doesn't ripple. The Tabs control seem to be missing their ripple but I'm not sure if that's from this PR. |
Also I noticed that the mouse cursor doesn't indicate the item is clickable. So for consistency we should either:
|
Just fyi, both Windows File Explorer and MUI have the click cursor but no ripple. MudList doesn't ripple but NavMenu does |
@henon you need to make a decision, if we accept then when, because there is currently other big TreeView PR going, either after or before. |
It looks like this won't be conflicting with our TreeView PR #8661. We can merge the ripple now and I'll resolve any conflicts in my PR. |
Description
resolves #8570
How Has This Been Tested?
visually, unit-tests
Types of changes
Screencast_20240412_221223.webm
Checklist
dev
).