Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudTreeView: Add ripple effect (#8570) #8669

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

meenzen
Copy link
Contributor

@meenzen meenzen commented Apr 12, 2024

Description

resolves #8570

How Has This Been Tested?

visually, unit-tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
Screencast_20240412_221223.webm

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement New feature or request PR: needs review labels Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (28bc599) to head (83abe51).
Report is 39 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8669      +/-   ##
==========================================
+ Coverage   89.82%   90.06%   +0.23%     
==========================================
  Files         412      418       +6     
  Lines       11878    12008     +130     
  Branches     2364     2366       +2     
==========================================
+ Hits        10670    10815     +145     
+ Misses        681      659      -22     
- Partials      527      534       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anu6is
Copy link
Contributor

Anu6is commented Apr 12, 2024

You should probably include a bool property Ripple that allows consumers to enable/disable the ripple effect.
It should also be disabled for disabled tree view items.

@meenzen
Copy link
Contributor Author

meenzen commented Apr 12, 2024

@Anu6is I've added the Ripple property and made sure there's no ripple when disabled.

@danielchalmers
Copy link
Contributor

The "Expand on double click" doesn't ripple.

The Tabs control seem to be missing their ripple but I'm not sure if that's from this PR.

@meenzen
Copy link
Contributor Author

meenzen commented Apr 13, 2024

Expand on double click looks odd with a ripple because the animation is shown for each click, but the second one cancels the first.

Also I noticed that the mouse cursor doesn't indicate the item is clickable. So for consistency we should either:

  • Set the click cursor and enable the ripple
  • Keep the click cursor and ripple disabled

@danielchalmers
Copy link
Contributor

danielchalmers commented Apr 13, 2024

Just fyi, both Windows File Explorer and MUI have the click cursor but no ripple.

MudList doesn't ripple but NavMenu does

@ScarletKuro
Copy link
Member

@henon you need to make a decision, if we accept then when, because there is currently other big TreeView PR going, either after or before.

@henon
Copy link
Collaborator

henon commented Apr 15, 2024

It looks like this won't be conflicting with our TreeView PR #8661. We can merge the ripple now and I'll resolve any conflicts in my PR.

@danielchalmers danielchalmers removed their request for review April 15, 2024 18:25
@henon henon merged commit 80c8d85 into MudBlazor:dev Apr 15, 2024
4 checks passed
@meenzen meenzen deleted the feat/tree-view-ripple branch April 15, 2024 19:44
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudTreeView: Add click animation to activated item
5 participants