Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangePicker: Fix margin top missing when label is set #8688

Merged
merged 10 commits into from
Apr 15, 2024

Conversation

ralvarezing
Copy link
Contributor

Description

A label was not retrived in the MudInput when building css classes.
This is following the rework on inputs margins at #8540 and #8623

fixes #8673

How Has This Been Tested?

Margin verification check through the docs project in the following components:
Autocomplete, Checkbox, Field, FileUpload, Form, NumericField, Radio, Select, Slider, Switch, TextField, ToogleGroup
ColorPicker, DatePicker, DateRangePicker, TimePicker

If any component (input components) is missing in this list, please let me know :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (28bc599) to head (829a252).
Report is 42 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8688      +/-   ##
==========================================
+ Coverage   89.82%   90.03%   +0.20%     
==========================================
  Files         412      418       +6     
  Lines       11878    12006     +128     
  Branches     2364     2366       +2     
==========================================
+ Hits        10670    10810     +140     
+ Misses        681      661      -20     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this feature

@henon henon merged commit 3e4270b into MudBlazor:dev Apr 15, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 15, 2024

@ralvarezing Thanks!
@igotinfected FYI

@henon henon changed the title DateRangePicker: Margin top missing when label is set DateRangePicker: Fix margin top missing when label is set Apr 15, 2024
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateRangePicker: missing margin-top
3 participants