-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DateRangePicker: Fix margin top missing when label is set #8688
DateRangePicker: Fix margin top missing when label is set #8688
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8688 +/- ##
==========================================
+ Coverage 89.82% 90.03% +0.20%
==========================================
Files 412 418 +6
Lines 11878 12006 +128
Branches 2364 2366 +2
==========================================
+ Hits 10670 10810 +140
+ Misses 681 661 -20
- Partials 527 535 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this feature
@ralvarezing Thanks! |
Description
A label was not retrived in the MudInput when building css classes.
This is following the rework on inputs margins at #8540 and #8623
fixes #8673
How Has This Been Tested?
Margin verification check through the docs project in the following components:
Autocomplete, Checkbox, Field, FileUpload, Form, NumericField, Radio, Select, Slider, Switch, TextField, ToogleGroup
ColorPicker, DatePicker, DateRangePicker, TimePicker
If any component (input components) is missing in this list, please let me know :)
Types of changes
Checklist
dev
).