Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add Documentation PR type #8689

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

danielchalmers
Copy link
Contributor

Description

In order to keep things nicely organized

I was personally using the enhancement tag since it seemed to fit, but it had to be manually changed to docs so it would spam the changelog.

This will cover all XML documentation and website changes.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

In order to keep things nicely organized
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (28bc599) to head (779f859).
Report is 45 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8689      +/-   ##
==========================================
+ Coverage   89.82%   90.08%   +0.25%     
==========================================
  Files         412      418       +6     
  Lines       11878    12018     +140     
  Branches     2364     2366       +2     
==========================================
+ Hits        10670    10826     +156     
+ Misses        681      659      -22     
- Partials      527      533       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperson2000
Copy link
Sponsor Contributor

I have a branch with XML documentation changes I haven't PR'ed yet, if you need a PR to test this with.

@danielchalmers
Copy link
Contributor Author

danielchalmers commented Apr 14, 2024

I have a branch with XML documentation changes I haven't PR'ed yet, if you need a PR to test this with.

That would be great, thank you! Just need review from MIke

@mikes-gh mikes-gh merged commit beeb256 into MudBlazor:dev Apr 15, 2024
5 checks passed
@mikes-gh
Copy link
Contributor

Thanks @danielchalmers

@mikes-gh
Copy link
Contributor

I have a branch with XML documentation changes I haven't PR'ed yet, if you need a PR to test this with.

@jperson2000 Thanks that would be great

@jperson2000
Copy link
Sponsor Contributor

I have a branch with XML documentation changes I haven't PR'ed yet, if you need a PR to test this with.

@jperson2000 Thanks that would be great

Thanks for this change! I've submitted this PR with the new "docs" PR type: #8701

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@ScarletKuro ScarletKuro added build Changes to the project build system and removed PR: needs review labels May 1, 2024
@danielchalmers danielchalmers deleted the patch-2 branch May 3, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes to the project build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants