Input: Add required and aria-required attributes (#5437)

[igotinfected]

Description

Implemented the required and aria-required attributes in most components that emit inputs.

Affected components:

• MudInput, MudRangeInput, MudMask
• MudTextField, MudAutocomplete, MudSelect, MudNumericField
• MudDatePicker, MudDateRangerPicker, MudColorPicker
• MudFileUpload
• MudCheckBox, MudSwitch, MudRadio

Resolves #5437

How Has This Been Tested?

Visually + unit tests.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• The PR is submitted to the correct branch (dev).
• My code follows the code style of this project.
• I've added relevant tests.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (28bc599) to head (9c61b63).
Report is 76 commits behind head on dev.

❗ Current head 9c61b63 differs from pull request most recent head b9d2d1f. Consider uploading reports for the commit b9d2d1f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #8691      +/-   ##
==========================================
+ Coverage   89.82%   90.13%   +0.30%     
==========================================
  Files         412      419       +7     
  Lines       11878    12181     +303     
  Branches     2364     2397      +33     
==========================================
+ Hits        10670    10979     +309     
+ Misses        681      664      -17     
- Partials      527      538      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danielchalmers]

So stoked for all these accessibility changes!

I do think all inputs should have required; MudCheckBox, MudSwitch, MudRadio, etc. Seems fairly standard and I don't see the downside.

[igotinfected]

So stoked for all these accessibility changes!

I do think all inputs should have required; MudCheckBox, MudSwitch, MudRadio, etc. Seems fairly standard and I don't see the downside.

Yup, will add MudCheckBox, MudSwitch, and MudRadioGroup (all three inherit from MudFormComponent which is the class containing Required logic). MudRadio on its own is not a form-control.

[igotinfected]

So stoked for all these accessibility changes!
I do think all inputs should have required; MudCheckBox, MudSwitch, MudRadio, etc. Seems fairly standard and I don't see the downside.

Yup, will add MudCheckBox, MudSwitch, and MudRadioGroup (all three inherit from MudFormComponent which is the class containing Required logic). MudRadio on its own is not a form-control.

Done. For MudRadioGroup the MDN doc states that the element with the role="radiogroup" attribute should also have required & aria-required, so that's what I did.

[henon]

@danielchalmers do you want to flip all these Disable* in colorpicker for v7? In a separate PR of course

[danielchalmers]

Sure if someone can remind me after this is merged

[henon]

Sorry, the branch is heavily conflicted. The code base is mutating pretty heavily due to all the breaking changes we make.

[igotinfected]

Sorry, the branch is heavily conflicted. The code base is mutating pretty heavily due to all the breaking changes we make.

No worries! Will clean it up when I find the time :)

[igotinfected]

Well turns out the conflicts were all due to my other recently merged PRs... 😇

[henon]

Thanks again