Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BooleanInput: Fix form validation (#8690) #8693

Merged

Conversation

igotinfected
Copy link
Contributor

Description

Another form validation fix 😉

This time for boolean inputs, the Touched property was not being updated when the state was changed using key presses. Moved the Touched change to the base method that is called for every update to avoid having to change Touched in multiple logic branches.

Fixes #8690

How Has This Been Tested?

Visually + unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
chrome_7FaohzJBjY.mp4

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (28bc599) to head (15bb9c7).
Report is 46 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8693      +/-   ##
==========================================
+ Coverage   89.82%   90.08%   +0.25%     
==========================================
  Files         412      418       +6     
  Lines       11878    12018     +140     
  Branches     2364     2367       +3     
==========================================
+ Hits        10670    10826     +156     
+ Misses        681      659      -22     
- Partials      527      533       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon April 14, 2024 19:45
@henon henon merged commit 45d575d into MudBlazor:dev Apr 16, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 16, 2024

Thanks @igotinfected

@igotinfected igotinfected deleted the fix/mudcheckbox-blocks-form-validation branch April 16, 2024 19:10
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckBox: Ticking a required CheckBox within a Form keeps the form invalid
3 participants