-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: Remove 'Value not null' criteria for FilterDefinition #8706
Conversation
…r property to be true
Hi. Thanks for PR. Please, add a bUnit test to test this case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8706 +/- ##
==========================================
+ Coverage 89.82% 90.11% +0.28%
==========================================
Files 412 418 +6
Lines 11878 12050 +172
Branches 2364 2365 +1
==========================================
+ Hits 10670 10859 +189
+ Misses 681 658 -23
- Partials 527 533 +6 ☔ View full report in Codecov by Sentry. |
Added test to check scenarios of filter definition with value, without value and filter not applied. |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks good. Thanks, @aditya119!
Description
Fixes #8702
On MudDataGrid, when
is empty
oris not empty
filters are applied. Filter icon does not show filled funnel.This creates confusion whether filter was applied or not.
The
hasFilter
property inHeaderCell.razor.cs
was returning false when filter definition did not have a value.Since,
is empty
andis not empty
filter definitions will never have a value so datagrid column header was showing empty funnel despite filter being applied.The logic was updated to ignore the check for
Value
when checking whether columnhasFilter
.How Has This Been Tested?
Visually tested.
Types of changes
Checklist
dev
).