Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView: Add disabled style #8707

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

Like MudList

Consolidates the Hover and Dense styles into a Basic Customization example, then adds a Disabled option to it.

Adds a note to the ExpandOnClick example about how to control the ripple.

How Has This Been Tested?

visually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Like MudList

Consolidates the Hover and Dense styles into a Basic Customization example, then adds a Disabled option to it.

Adds a note to the ExpandOnClick example about how to control the ripple.
@github-actions github-actions bot added enhancement New feature or request PR: needs review labels Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (28bc599) to head (9d21e5c).
Report is 56 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8707      +/-   ##
==========================================
+ Coverage   89.82%   90.06%   +0.23%     
==========================================
  Files         412      418       +6     
  Lines       11878    12049     +171     
  Branches     2364     2365       +1     
==========================================
+ Hits        10670    10852     +182     
+ Misses        681      661      -20     
- Partials      527      536       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Collaborator

henon commented Apr 16, 2024

Awesome. Can you revert the examples completely because I did the same in my PR and then I'll have to resolve the conflict. Here is what I did:

image

@henon
Copy link
Collaborator

henon commented Apr 16, 2024

I added your description about Disabled to my usage example already.

Copy link
Collaborator

@henon henon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert all changes to examples

@henon
Copy link
Collaborator

henon commented Apr 16, 2024

As for checkbox vs check box, I'd say we should go for the former as does wikipedia: https://en.wikipedia.org/wiki/Checkbox

@danielchalmers
Copy link
Contributor Author

@henon Reverted examples!

BTW: Check Box

@henon
Copy link
Collaborator

henon commented Apr 16, 2024

@henon Reverted examples!

Thanks!

BTW: Check Box

I think we'll change that. I noticed it just now because resharper showed "check box" as spelling error. Then I looked it up.

@henon henon merged commit ec1a5bf into MudBlazor:dev Apr 16, 2024
4 checks passed
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants