Menu: Add AriaLabel property (#5783)
#8710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8710 +/- ##
==========================================
+ Coverage 89.82% 90.14% +0.31%
==========================================
Files 412 419 +7
Lines 11878 12181 +303
Branches 2364 2397 +33
==========================================
+ Hits 10670 10980 +310
+ Misses 681 664 -17
- Partials 527 537 +10 ☔ View full report in Codecov by Sentry. |
Comment on lines
+31
to
+33
| [Parameter] | ||
| [Category(CategoryTypes.Menu.Behavior)] | ||
| public string? AriaLabel { get; set; } |
There was a problem hiding this comment.
Done! LMK if Sets the aria-label of the menu button when <see cref="ActivatorContent"/> is not set. sounds good
ScarletKuro
approved these changes
Apr 18, 2024
biegehydra
pushed a commit
to biegehydra/MudBlazor
that referenced
this pull request
Apr 26, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small improvement to
MudMenuby adding theAriaLabelproperty as was discussed in the linked issue.Also made use of the
AriaLabelproperty in some of the documentation examples.Resolves #5783
How Has This Been Tested?
Visually + unit tests.
Type of Changes
Checklist
dev).