Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDialog: Fix content not stretched in fullscreen mode #8743

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

Apparently this was a regression which I expect was caused by the addition of a Focus Trap. The dialog content was expecting a flex parent, but the focus trap intercepted that.

This adds classes to the MudFocusTrap and the container for the child content so you can apply styles and debug the layout easier by default.

With those extra classes I applied flex to the intemediary components to make the dialog content grow as intended. Flex is the easier way to do this.

Resolves #5651
Resolves #6994

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before

image

After

image

I had to hide the Scroll to Top FAB in those images because for some reason they are visible over the dialog.

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Apparently this was a regression which I expect was caused by the addition of a Focus Trap. The dialog content was expecting a flex parent, but the focus trap intercepted that.

This adds classes to the MudFocusTrap and the container for the child content so you can apply styles and debug the layout easier by default.

With those extra classes I applied flex to the intemediary components to make the dialog content grow as intended.
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 18, 2024
@henon henon changed the title Dialog: Stretch content so actions are at the end MudDialog: Stretch content so actions are at the end Apr 18, 2024
@danielchalmers
Copy link
Contributor Author

@henon Title may want to mention that this is a fix or that it only applies to fullscreen

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (28bc599) to head (74443a9).
Report is 77 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8743      +/-   ##
==========================================
+ Coverage   89.82%   90.09%   +0.26%     
==========================================
  Files         412      419       +7     
  Lines       11878    12182     +304     
  Branches     2364     2397      +33     
==========================================
+ Hits        10670    10975     +305     
+ Misses        681      667      -14     
- Partials      527      540      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon changed the title MudDialog: Stretch content so actions are at the end MudDialog: Fix content not stretched in fullscreen mode Apr 18, 2024
@henon henon merged commit 09cb257 into MudBlazor:dev Apr 18, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
2 participants