-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudTreeView: Move checkbox icon customization from item to treeview #8750
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8750 +/- ##
==========================================
+ Coverage 89.82% 90.02% +0.19%
==========================================
Files 412 419 +7
Lines 11878 12176 +298
Branches 2364 2399 +35
==========================================
+ Hits 10670 10962 +292
+ Misses 681 669 -12
- Partials 527 545 +18 ☔ View full report in Codecov by Sentry. |
public bool Loading { get; set; } | ||
private string CheckedIcon => MudTreeRoot?.CheckedIcon ?? Icons.Material.Filled.CheckBox; | ||
|
||
private string UncheckedIcon => MudTreeRoot?.CheckedIcon ?? Icons.Material.Filled.CheckBoxOutlineBlank; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copypaste error is responsible for issue #8940
Description
Follow-up to #8661
It just doesn't make sense to be able to set different per-item checkbox icons in a tree view, so I moved the checkbox icon parameters into MudTreeView. Also discovered some minor things we overlooked in #8661
How Has This Been Tested?
existing tests
Type of Changes
Checklist
dev
).