Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudTreeView: Move checkbox icon customization from item to treeview #8750

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

henon
Copy link
Collaborator

@henon henon commented Apr 19, 2024

Description

Follow-up to #8661

It just doesn't make sense to be able to set different per-item checkbox icons in a tree view, so I moved the checkbox icon parameters into MudTreeView. Also discovered some minor things we overlooked in #8661

How Has This Been Tested?

existing tests

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@henon henon added API change API that needs approval v7 New major MudBlazor version and removed PR: needs review labels Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.02%. Comparing base (28bc599) to head (e2c410e).
Report is 82 commits behind head on dev.

Files Patch % Lines
...lazor/Components/TreeView/MudTreeViewItem.razor.cs 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8750      +/-   ##
==========================================
+ Coverage   89.82%   90.02%   +0.19%     
==========================================
  Files         412      419       +7     
  Lines       11878    12176     +298     
  Branches     2364     2399      +35     
==========================================
+ Hits        10670    10962     +292     
+ Misses        681      669      -12     
- Partials      527      545      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon requested a review from ScarletKuro April 19, 2024 12:30
@henon henon merged commit d8723e1 into MudBlazor:dev Apr 21, 2024
4 of 5 checks passed
@henon henon deleted the treeview-checkbox branch April 22, 2024 01:36
public bool Loading { get; set; }
private string CheckedIcon => MudTreeRoot?.CheckedIcon ?? Icons.Material.Filled.CheckBox;

private string UncheckedIcon => MudTreeRoot?.CheckedIcon ?? Icons.Material.Filled.CheckBoxOutlineBlank;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copypaste error is responsible for issue #8940

henon added a commit to henon/MudBlazor that referenced this pull request May 11, 2024
henon added a commit to henon/MudBlazor that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accidental break API change API that needs approval breaking change v7 New major MudBlazor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants