-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inputs: Add typography customization #8754
Conversation
still need to override the font inheriting
I need to know if this is on the right track and which controls I should apply this to. Check Box, Switch, etc? |
@jperson2000 Would love to know what you think |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8754 +/- ##
==========================================
+ Coverage 89.82% 90.05% +0.22%
==========================================
Files 412 421 +9
Lines 11878 12302 +424
Branches 2364 2438 +74
==========================================
+ Hits 10670 11078 +408
+ Misses 681 670 -11
- Partials 527 554 +27 ☔ View full report in Codecov by Sentry. |
Will the default typography of textfields stay the same as before? In other words, is this visually breaking? |
@henon Everything stays the same, the styles are just moved to |
Thanks! |
Description
Adds
Typo.input
so you can control the default input typography like you can do withTypo.button
, then uses that as the default for the newTypo
property inMudBaseInput
.This only applies to inputs and not controls like Check Box or Switch because they use
body1
.Uses the
lh
unit which raises browser support level but significantly simplifies the line height. To ease the maintenance burden and set expectations, I added a note to the README about staying up to date so that we aren't tied down to ancient versions. Note: Blazor only supports the latest browser versions.Resolves #8337
I think the ideal solution might be to scale the entire input up with relative units, but this implementation fits in with our current approach.
How Has This Been Tested?
Type of Changes
Text Field example:
Checklist
dev
).