Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudRTLProvider: Use ParameterState #8765

Merged
merged 1 commit into from
Apr 21, 2024
Merged

MudRTLProvider: Use ParameterState #8765

merged 1 commit into from
Apr 21, 2024

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 20, 2024

Description

Remove logic in RightToLeft property

How Has This Been Tested?

none, is there any specific way to test it? The RTL component seems to work

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 20, 2024
@ScarletKuro ScarletKuro requested a review from henon April 20, 2024 20:12
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.04%. Comparing base (28bc599) to head (17a19b4).
Report is 90 commits behind head on dev.

Files Patch % Lines
...zor/Components/RTLProvider/MudRTLProvider.razor.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8765      +/-   ##
==========================================
+ Coverage   89.82%   90.04%   +0.21%     
==========================================
  Files         412      419       +7     
  Lines       11878    12182     +304     
  Branches     2364     2397      +33     
==========================================
+ Hits        10670    10969     +299     
+ Misses        681      670      -11     
- Partials      527      543      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 655b2d2 into MudBlazor:dev Apr 21, 2024
5 checks passed
@ScarletKuro ScarletKuro deleted the rtl branch April 21, 2024 16:51
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants