Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudProgressLinear: fix XMLDoc of Value parameter #8803

Conversation

markushaslinger
Copy link
Contributor

Description

The Value parameter used the same XMLDoc summary/description as the Max parameter.
Changed that to describe what value should be set for this parameter: the current one to display, which should be between min & max.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added docs Related to docs PR: needs review labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (28bc599) to head (51efe62).
Report is 112 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8803      +/-   ##
==========================================
+ Coverage   89.82%   90.11%   +0.28%     
==========================================
  Files         412      420       +8     
  Lines       11878    12206     +328     
  Branches     2364     2407      +43     
==========================================
+ Hits        10670    10999     +329     
+ Misses        681      664      -17     
- Partials      527      543      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon April 24, 2024 11:23
@henon henon merged commit 528ac53 into MudBlazor:dev Apr 24, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 24, 2024

Thanks!

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants