Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix MudDateRangePicker editable example #8806

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

birdalicious
Copy link
Contributor

Docs - Date range picker editable example fixed

Description

Editable parameter does not exist changed to ReadOnly

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests. N/A

@github-actions github-actions bot added docs Related to docs PR: needs review labels Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (28bc599) to head (9eca8a6).
Report is 115 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8806      +/-   ##
==========================================
+ Coverage   89.82%   90.11%   +0.28%     
==========================================
  Files         412      420       +8     
  Lines       11878    12213     +335     
  Branches     2364     2409      +45     
==========================================
+ Hits        10670    11006     +336     
+ Misses        681      664      -17     
- Partials      527      543      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

ScarletKuro commented Apr 24, 2024

Hi, Thanks for PR.

@henon is this something that should be added to #8771 or it's just something old / added by mistake.
Also, shouldn't we renamed the Editable for MudPicker to ReadOnly? Feels wrong that we have different property names for same thing.

@ScarletKuro ScarletKuro requested a review from henon April 24, 2024 21:28
@henon
Copy link
Collaborator

henon commented Apr 25, 2024

Yes, ReadOnly is the new standard now. We have to roll it out where it is not yet used.

@henon henon changed the title daterange picker docs editable example fix Docs: Fix MudDateRangePicker editable example Apr 25, 2024
@henon henon merged commit ea155ac into MudBlazor:dev Apr 25, 2024
5 checks passed
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Co-authored-by: Jack Bird <jbird@salunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants