-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudDataGrid: Add ICloneStrategy #8851
Conversation
@henon will wait your opinion on that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8851 +/- ##
==========================================
+ Coverage 89.82% 90.13% +0.30%
==========================================
Files 412 423 +11
Lines 11878 12309 +431
Branches 2364 2431 +67
==========================================
+ Hits 10670 11095 +425
+ Misses 681 665 -16
- Partials 527 549 +22 ☔ View full report in Codecov by Sentry. |
Makes sense of course. This is an application of the Strategy Pattern, shall we name it |
I like this name, I will rename it later and do tests. I guess the explanation that it has to be a deep clone and not shallow one can be achieved via xmldocs. |
8fdc150
to
fa42514
Compare
Renamed to |
I need tmr to tweak the xml doc, so do not merge. |
OK, converted to draft for now |
ready for merge |
Awesome. Thanks! |
Description
Resolves: #8848
Read my two comments for details: #8848 (comment), #8848 (comment)
In short: This can kill two birds with one stone.
JsonSerializerContext
.Two built in resolvers: STJ without any custom configuration (default), ICloneable (not sure if it makes sense to provide second option when its easy to implement by other parties, but i thought I can use it in test as an showcase, tho I could just add it in test project)
How Has This Been Tested?
Added new bUnit tests
Type of Changes
Checklist
dev
).