Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudRipple: Fix ripple conditions #8866

Merged
merged 2 commits into from
May 4, 2024
Merged

Conversation

meenzen
Copy link
Contributor

@meenzen meenzen commented May 3, 2024

Description

These conditions weren't properly updated during the recent DisableRipple -> Ripple refactor.

How Has This Been Tested?

unit

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 3, 2024
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (28bc599) to head (7e4d304).
Report is 135 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8866      +/-   ##
==========================================
+ Coverage   89.82%   90.11%   +0.28%     
==========================================
  Files         412      421       +9     
  Lines       11878    12299     +421     
  Branches     2364     2430      +66     
==========================================
+ Hits        10670    11083     +413     
+ Misses        681      666      -15     
- Partials      527      550      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Collaborator

henon commented May 4, 2024

Thanks @meenzen !

@henon henon merged commit 68f039c into MudBlazor:dev May 4, 2024
5 checks passed
@meenzen meenzen deleted the fix/ripple-conditions branch May 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants