MudTable: Add ability to control which rows are editable #8873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8873 +/- ##
==========================================
+ Coverage 89.82% 90.24% +0.41%
==========================================
Files 412 425 +13
Lines 11878 12292 +414
Branches 2364 2409 +45
==========================================
+ Hits 10670 11093 +423
+ Misses 681 668 -13
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. |
biegehydra
force-pushed
the
Table/RowEditableFunc
branch
from
c2b68fe
to
c426233
Compare
ScarletKuro
reviewed
May 6, 2024
src/MudBlazor.UnitTests.Viewer/MudBlazor.UnitTests.Viewer.csproj
Outdated
Show resolved
Hide resolved
| @@ -114,6 +114,8 @@ private EventCallback<MouseEventArgs> RowMouseLeaveEventCallback | |||
|
|
|||
| private void StartEditingItem(bool buttonClicked) | |||
| { | |||
| if (!IsEditable) return; | |||
There was a problem hiding this comment.
@henon doesn't seems like your statement is correct #7787 (comment)
There was a problem hiding this comment.
Yes, I was mistaken, the rename will be done via #8892 which is not yet merged.
7 tasks
biegehydra
force-pushed
the
Table/RowEditableFunc
branch
from
c426233
to
493d7e1
Compare
ScarletKuro
approved these changes
May 7, 2024
|
Thanks @biegehydra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened #7787 because that PR became a mess
Description
It would be useful to have control over which items are editable on a per row basis. Often times there are certain records that you don't want to allow to be edited. This PR lets you provide a
Func<T, bool>to control which items are editable.This is accomplished by treating
IsEditableon theMudTrandIsEditableon theMudTableas separate values where previously they were essentially the same.Here's a quick example where editing is only allowed when the temperature is greater than 20.
2023-11-20.01-43-30.mp4
How Has This Been Tested?
Types of changes
I don't really think this is a breaking change, but I am sure there is some edge case that is affected by this change.
Checklist:
dev).