Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudForm: Add Spacing property #8880

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

danielchalmers
Copy link
Contributor

@danielchalmers danielchalmers commented May 5, 2024

Description

Turns the MudForm into a flex display and uses that to add a gap-* class based directly on a new Spacing property.
Resolves #8859.

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)
video2.mp4

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added enhancement New feature or request PR: needs review labels May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (28bc599) to head (13870bb).
Report is 163 commits behind head on dev.

❗ Current head 13870bb differs from pull request most recent head e20984b. Consider uploading reports for the commit e20984b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8880      +/-   ##
==========================================
+ Coverage   89.82%   90.18%   +0.35%     
==========================================
  Files         412      423      +11     
  Lines       11878    12275     +397     
  Branches     2364     2407      +43     
==========================================
+ Hits        10670    11070     +400     
+ Misses        681      670      -11     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers danielchalmers changed the title Form: Add Spacing property MudForm: Add Spacing property May 5, 2024
@henon
Copy link
Collaborator

henon commented May 7, 2024

LGTM, just a test is missing. That check for the application of the class
As for unifying spacing between the various components I'd say let's do it in a separate PR.

@danielchalmers
Copy link
Contributor Author

@henon Test added. Do you want me to squeeze in the spacing unification before preview2?

@henon henon merged commit 6225f78 into MudBlazor:dev May 7, 2024
2 checks passed
@henon
Copy link
Collaborator

henon commented May 7, 2024

Do you want me to squeeze in the spacing unification before preview2?

No hurry. We'll do as many previews as we need.

@danielchalmers danielchalmers deleted the form-spacing branch May 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudForm: Optional margin between items
2 participants