Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Color.Surface and Color.Transparent #8889

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Remove unused Color.Surface and Color.Transparent #8889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd8d232
Remove unused `Color.Surface`
danielchalmers May 6, 2024
3557366
fix test
danielchalmers May 6, 2024
3ba4690
Remove Color.Transparent
danielchalmers Jul 10, 2024
2a51974
fix
danielchalmers Jul 10, 2024
9f7cc71
Merge branch 'dev' into color-surface
danielchalmers Jul 10, 2024
be7460a
not transparent if avatar group outlined
danielchalmers Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MudBlazor.Docs/Components/DocsPage.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</MudToolBar>
</MudContainer>
}
<MudDrawer Class="docs-page-content-navigation-drawer" @bind-Open="_contentDrawerOpen" Breakpoint="Breakpoint.Lg" Anchor="Anchor.End" ClipMode="DrawerClipMode.Always" Elevation="0" Color="Color.Transparent">
<MudDrawer Class="docs-page-content-navigation-drawer" @bind-Open="_contentDrawerOpen" Breakpoint="Breakpoint.Lg" Anchor="Anchor.End" ClipMode="DrawerClipMode.Always" Elevation="0">
@if (_displayView)
{
<MudText Typo="Typo.subtitle1" Class="title" GutterBottom="true">
Expand Down
2 changes: 1 addition & 1 deletion src/MudBlazor.Docs/Shared/DocsLayout.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@layout MainLayout

<MudLayout Class="mudblazor-docs">
<MudAppBar Class="docs-appbar-filter" Color="Color.Transparent" Elevation="0"></MudAppBar>
<MudAppBar Class="docs-appbar-filter" Elevation="0"></MudAppBar>
<MudAppBar Class="docs-appbar" Elevation="0">
<Appbar DrawerToggleCallback="ToggleDrawer" />
</MudAppBar>
Expand Down
2 changes: 1 addition & 1 deletion src/MudBlazor.UnitTests/Components/ProgressLinearTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ public void TestClassesForSize(Size size, string expectedString)

[Test]
[TestCase(Color.Success, "success")]
[TestCase(Color.Surface, "surface")]
[TestCase(Color.Tertiary, "tertiary")]
[TestCase(Color.Error, "error")]
public void TestClassesForColor(Color color, string expectedString)
{
Expand Down
2 changes: 0 additions & 2 deletions src/MudBlazor.UnitTests/Components/SliderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,7 @@ public void CheckInputSizeCssClass(Size size, string expectedSizeClass)
[TestCase(Color.Warning, "warning")]
[TestCase(Color.Error, "error")]
[TestCase(Color.Dark, "dark")]
[TestCase(Color.Transparent, "transparent")]
[TestCase(Color.Inherit, "inherit")]
[TestCase(Color.Surface, "surface")]
public void CheckColorCssClass(Color color, string expectedColorClass)
{
var comp = Context.RenderComponent<MudSlider<int>>(x => x.Add(p => p.Color, color));
Expand Down
2 changes: 1 addition & 1 deletion src/MudBlazor/Components/Avatar/MudAvatarGroup.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ partial class MudAvatarGroup : MudComponentBase
/// </summary>
[Parameter]
[Category(CategoryTypes.AvatarGroup.Appearance)]
public Color OutlineColor { get; set; } = Color.Surface;
public Color OutlineColor { get; set; }

/// <summary>
/// The size of the drop shadow when the number of avatars exceeds <see cref="Max"/>.
Expand Down
4 changes: 0 additions & 4 deletions src/MudBlazor/Enums/Color.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,7 @@ public enum Color
Error,
[Description("dark")]
Dark,
[Description("transparent")]
Transparent,
[Description("inherit")]
Inherit,
[Description("surface")]
Surface
}
}
5 changes: 0 additions & 5 deletions src/MudBlazor/Styles/abstracts/_colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@
background-color: var(--mud-palette-background-gray) !important;
}

.mud-theme-transparent {
color: inherit !important;
background-color: transparent !important;
}

.mud-transparent {
background-color: transparent !important;
}
Expand Down
14 changes: 3 additions & 11 deletions src/MudBlazor/Styles/components/_avatar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import '../abstracts/variables';
@import '../abstracts/variables';

.mud-avatar {
display: inline-flex;
Expand Down Expand Up @@ -89,16 +89,8 @@
}

&.mud-avatar-group-outlined {
&.mud-avatar-group-outlined-transparent {
.mud-avatar:not(.mud-avatar-outlined) {
border-color: transparent;
}
}

&.mud-avatar-group-outlined-surface {
.mud-avatar:not(.mud-avatar-outlined) {
border-color: var(--mud-palette-surface);
}
.mud-avatar:not(.mud-avatar-outlined) {
border-color: var(--mud-palette-surface);
}

@each $color in $mud-palette-colors {
Expand Down
Loading