Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudText: Return subtitle1 and subtitle2 to block elements (p) #8899

Merged
merged 1 commit into from
May 7, 2024

Conversation

danielchalmers
Copy link
Contributor

@danielchalmers danielchalmers commented May 6, 2024

Description

This was changed in #6061 to address accessibility and SEO concerns but broke backwards compatibility by making them inline spans instead of block elements. Most users were relying on this for the Align property (Fixes #8865). This returns them to block elements while not returning to headers.

In the future we should let the user decide which HTML tag they want to use: #8898.

How Has This Been Tested?

none

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 6, 2024
@danielchalmers danielchalmers requested a review from henon May 6, 2024 16:23
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (28bc599) to head (6b0d7cc).
Report is 154 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8899      +/-   ##
==========================================
+ Coverage   89.82%   90.23%   +0.40%     
==========================================
  Files         412      424      +12     
  Lines       11878    12286     +408     
  Branches     2364     2406      +42     
==========================================
+ Hits        10670    11086     +416     
+ Misses        681      668      -13     
- Partials      527      532       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit f47a442 into MudBlazor:dev May 7, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented May 7, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudText: Typo.subtitle1 and Typo.subtitle2 can no longer be centered using Align.Center
2 participants