Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudDatePicker: Fix GoToDate with Persian calendar #8909

Merged
merged 5 commits into from
May 8, 2024

Conversation

ajahangard
Copy link
Contributor

@ajahangard ajahangard commented May 7, 2024

Resolved issue #8905 in GoToDate() methods in MudDatePicker

Description

Fixes: #8905

How Has This Been Tested?

I have tested it manually.
I added relevant test case.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 7, 2024
@ScarletKuro
Copy link
Member

ScarletKuro commented May 7, 2024

Hi.
Thanks, I really appreciate in helping with the Persian Calendar.
Would it be hard for you to add a unit test based on the #8905 repro (or own code)?

@ScarletKuro ScarletKuro changed the title Persian calendar MudDatePicker: Fix GoToDate with Persian calendar May 7, 2024
@henon
Copy link
Collaborator

henon commented May 7, 2024

@ajahangard please understand that by providing a test for your fix you'll ensure that further work on the date picker will never ever break it again, at least not this aspect ;)

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (28bc599) to head (b69d7c5).
Report is 165 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8909      +/-   ##
==========================================
+ Coverage   89.82%   90.26%   +0.43%     
==========================================
  Files         412      425      +13     
  Lines       11878    12294     +416     
  Branches     2364     2409      +45     
==========================================
+ Hits        10670    11097     +427     
+ Misses        681      667      -14     
- Partials      527      530       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajahangard
Copy link
Contributor Author

@henon @ScarletKuro ,
Hi, relevant test added:
PersianCalendarTest_GoToDate()
It test the gotodate functionality on persian calendar.

@ScarletKuro ScarletKuro requested a review from henon May 8, 2024 07:54
@henon henon merged commit 4e271a6 into MudBlazor:dev May 8, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented May 8, 2024

Thanks @ajahangard

@ajahangard ajahangard deleted the PersianCalendar branch May 9, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudDatePicker With Persian Culture
3 participants