-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete: Treat all ways of closing overlay the same #8914
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8914 +/- ##
==========================================
+ Coverage 89.82% 90.22% +0.39%
==========================================
Files 412 424 +12
Lines 11878 12283 +405
Branches 2364 2411 +47
==========================================
+ Hits 10670 11082 +412
+ Misses 681 670 -11
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. |
@henon done but there's like a dozen other methods that are missing Async including the public |
Description
Previously if you would click the overlay it would trigger the menu close handler, but not if you tabbed away or set it programmatically.
Now we listen to the overlay, so any event that makes that close will call our close handler.
Resolves #3825
Resolves #3824
How Has This Been Tested?
Type of Changes
Before (tabbing away does not coerce but clicking does):
video3.mp4
After (both tabbing away and clicking coerces):
video2.mp4
Checklist
dev
).