Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Treat all ways of closing overlay the same #8914

Merged
merged 3 commits into from
May 9, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

Previously if you would click the overlay it would trigger the menu close handler, but not if you tabbed away or set it programmatically.
Now we listen to the overlay, so any event that makes that close will call our close handler.

Resolves #3825
Resolves #3824

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before (tabbing away does not coerce but clicking does):

video3.mp4

After (both tabbing away and clicking coerces):

video2.mp4

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.22%. Comparing base (28bc599) to head (d515bef).
Report is 170 commits behind head on dev.

Files Patch % Lines
...r/Components/Autocomplete/MudAutocomplete.razor.cs 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8914      +/-   ##
==========================================
+ Coverage   89.82%   90.22%   +0.39%     
==========================================
  Files         412      424      +12     
  Lines       11878    12283     +405     
  Branches     2364     2411      +47     
==========================================
+ Hits        10670    11082     +412     
+ Misses        681      670      -11     
- Partials      527      531       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Contributor Author

@henon done but there's like a dozen other methods that are missing Async including the public Clear. I think these should be done in a separate PR

@henon henon merged commit d4b477e into MudBlazor:dev May 9, 2024
3 of 4 checks passed
@danielchalmers danielchalmers deleted the autocomplete-coerce-tab branch May 17, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudAutocomplete CoerceText not working on blur MudAutoComplete selectValueOnTab reset on invalid entry
3 participants