Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudIcon: Add role="img" #8915

Merged
merged 1 commit into from
May 8, 2024
Merged

MudIcon: Add role="img" #8915

merged 1 commit into from
May 8, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Img_role#svg_and_roleimg
https://stackoverflow.com/a/4756461
https://stackoverflow.com/questions/49197524/what-is-the-default-aria-role-for-an-svg

(probably) Resolves #3315

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (28bc599) to head (39b6b01).
Report is 165 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8915      +/-   ##
==========================================
+ Coverage   89.82%   90.21%   +0.38%     
==========================================
  Files         412      425      +13     
  Lines       11878    12293     +415     
  Branches     2364     2409      +45     
==========================================
+ Hits        10670    11090     +420     
+ Misses        681      670      -11     
- Partials      527      533       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit a6153b6 into MudBlazor:dev May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudIcon is not rendering Title
3 participants