Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudContainer: Add Gutters property #8934

Merged
merged 2 commits into from
May 11, 2024

Conversation

danielchalmers
Copy link
Contributor

@danielchalmers danielchalmers commented May 10, 2024

Description

I use the MudContainer and currently have to override the styles to avoid the extra padding added. This lets you control it with a property like several other controls.

Interestingly there was an unused mud-container-disable-gutters, but I reversed the way the padding is handled in a fashion like #8586. Normally it's added then removed but this way it's only added if Gutters is actually enabled in the first place. This should be the general convention IMO because it avoid usage of !important which messes with consumers' overrides.

How Has This Been Tested?

unit, visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Default vs Gutters=false

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Interestingly there was an unused `mud-container-disable-gutters` but I reversed the way the padding is handled in a fashion like MudBlazor#8586. Normally it's added then removed. This way it's only added in the first place if Gutters is actually enabled. This means we dont have to mess around with `!important` and ruin people's overrides.
@github-actions github-actions bot added enhancement New feature or request PR: needs review labels May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (28bc599) to head (6d70680).
Report is 176 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8934      +/-   ##
==========================================
+ Coverage   89.82%   90.45%   +0.62%     
==========================================
  Files         412      419       +7     
  Lines       11878    12190     +312     
  Branches     2364     2380      +16     
==========================================
+ Hits        10670    11026     +356     
+ Misses        681      630      -51     
- Partials      527      534       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 1ac6d31 into MudBlazor:dev May 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants