Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities: Increase max spacing/gap to 20 from 16 #8943

Merged
merged 1 commit into from
May 11, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

80px up from 64px.
Resolves #8942
MudForm now allows gap-0
MudStack no longer allows negative gap which was invalid and adds more documentation

Not sure if I missed any.

How Has This Been Tested?

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers
Copy link
Contributor Author

20 was suggested by @henon due to Bootstrap only offering up to 20, Vuetify the same

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (28bc599) to head (a0e5476).
Report is 177 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8943      +/-   ##
==========================================
+ Coverage   89.82%   90.45%   +0.62%     
==========================================
  Files         412      419       +7     
  Lines       11878    12190     +312     
  Branches     2364     2380      +16     
==========================================
+ Hits        10670    11026     +356     
+ Misses        681      630      -51     
- Partials      527      534       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Collaborator

henon commented May 10, 2024

I did misremember. Vuetify offers only up to 16. But Bootstrap offers up to 20 and is used by so many that I guess it is a good idea to orient ourselves after them with respect to these classes.

@henon
Copy link
Collaborator

henon commented May 10, 2024

Does it increase padding utility classes also? i.e. pa-20 ?

@danielchalmers
Copy link
Contributor Author

danielchalmers commented May 10, 2024

Does it increase padding utility classes also? i.e. pa-20 ?

@henon Yes, they're listed under Spacing

image

image

image

@henon henon merged commit 669ffce into MudBlazor:dev May 11, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented May 11, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilities: Increase max values from 16
3 participants