Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView: Update parent selection on item click in multi-selection mode #8957

Merged
merged 1 commit into from
May 13, 2024

Conversation

henon
Copy link
Collaborator

@henon henon commented May 13, 2024

Description

Follow-up to #8948

Alters the hierarchic behavior of multi-select treeview toward the expected behavior. Clicking child items will automatically alter
the selection state of their parents for consistency because clicking the parent also alters the selection state of its children.

treeview hierarchic selection

Before this change clicking children did not update the selection state of their parent(s)

How Has This Been Tested?

A unit test was adapted to check this behavior

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

…ti-selection and remove no longer needed custom checkbox example
@henon henon requested a review from ScarletKuro May 13, 2024 14:24
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 13, 2024
@henon henon added the v7 New major MudBlazor version label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (28bc599) to head (97a69a6).
Report is 191 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8957      +/-   ##
==========================================
+ Coverage   89.82%   90.48%   +0.65%     
==========================================
  Files         412      419       +7     
  Lines       11878    12210     +332     
  Branches     2364     2385      +21     
==========================================
+ Hits        10670    11048     +378     
+ Misses        681      627      -54     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 7422e0b into MudBlazor:dev May 13, 2024
5 checks passed
@henon henon deleted the treeview-fix branch May 13, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected v7 New major MudBlazor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants