Progress: Improve accessibility #9060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Format razor - Use `aria-live=polite` to announce changes to the screen reader. - Use `ToInvariantString` in Circular like Linear - Apply user attributes at the end so they can override our defaults - Adds aria min and max values for Circular - `DivClassname` -> `Classname` - `MagicNumber` fix naming violation
danielchalmers
added
accessibility
and removed
enhancement
|
cc @igotinfected 3 of 3 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #9060 +/- ##
==========================================
+ Coverage 89.82% 90.62% +0.79%
==========================================
Files 412 398 -14
Lines 11878 12372 +494
Branches 2364 2403 +39
==========================================
+ Hits 10670 11212 +542
+ Misses 681 621 -60
- Partials 527 539 +12 ☔ View full report in Codecov by Sentry. |
ScarletKuro
approved these changes
May 25, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aria-live=politeto announce changes to the screen reader.ToInvariantStringin Circular like LinearDivClassname->ClassnameMagicNumberfix naming violationHow Has This Been Tested?
visually
Type of Changes
Checklist
dev).