Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MudTabs: add WrapHeaders (#9108)" #9234

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

henon
Copy link
Collaborator

@henon henon commented Jun 21, 2024

Fixes: #9167
Fixes: #9237

This reverts commit e5bdc0e.

The team decided to roll back PR #9108 due to the following reasons:

  • It introduced a regression
  • The feature should have been rejected in the first place because multiple stacks of wrapped tabs are actually bad UX design
  • It complicates MudTabs for a feature that is actually outdated

@ZephyrZiggurat Notwithstanding the revert we thank you very much for contributing to the library and we hope you'll understand the team decision.

@meenzen FYI

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (28bc599) to head (091d4de).
Report is 292 commits behind head on dev.

Files Patch % Lines
src/MudBlazor/Components/Tabs/MudTabs.razor.cs 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9234      +/-   ##
==========================================
+ Coverage   89.82%   90.86%   +1.03%     
==========================================
  Files         412      401      -11     
  Lines       11878    12521     +643     
  Branches     2364     2433      +69     
==========================================
+ Hits        10670    11377     +707     
+ Misses        681      605      -76     
- Partials      527      539      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 9b365aa into MudBlazor:dev Jun 21, 2024
4 checks passed
@ScarletKuro ScarletKuro added bug Something does not work as intended/expected accidental break and removed PR: needs review bug Something does not work as intended/expected labels Jun 21, 2024
@henon henon deleted the mudtab_revert_wrapheaders branch June 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MudTabs slider has an issue with v7.0.0-rc and -rc2 MudTabs: Incorrect rendering of selected tab slider
2 participants