Fix LGTM updater class warnings (#2984)

* Fix LGTM updater class warnings

* Declare destructor in the correct location

src/updater.cpp

@@ -26,6 +26,7 @@
 #endif
 
 #include "pre_guard.h"
+#include <QPushButton>
 #include <QtConcurrent>
 #include "post_guard.h"
 
@@ -47,6 +48,10 @@ Updater::Updater(QObject* parent, QSettings* settings) : QObject(parent)
 
     feed = new dblsqd::Feed(QStringLiteral("https://feeds.dblsqd.com/MKMMR7HNSP65PquQQbiDIw"), QStringLiteral("release"));
 }
+Updater::~Updater()
+{
+    delete (feed);
+}
 
 // start the update process and figure out what needs to be done
 // if it's silent updates, do that right away, otherwise
@@ -250,14 +255,13 @@ void Updater::untarOnLinux(const QString& fileName)
 
 void Updater::updateBinaryOnLinux()
 {
-    // FIXME don't hardcode name in case we want to change it
     QFileInfo unzippedBinary(QStandardPaths::writableLocation(QStandardPaths::TempLocation) + "/" + unzippedBinaryName);
     auto systemEnvironment = QProcessEnvironment::systemEnvironment();
     auto appimageLocation = systemEnvironment.contains(QStringLiteral("APPIMAGE")) ?
                 systemEnvironment.value(QStringLiteral("APPIMAGE"), QString()) :
                 QCoreApplication::applicationFilePath();
 
-    QString installedBinaryPath(appimageLocation);
+    const QString& installedBinaryPath(appimageLocation);
 
     auto executablePermissions = unzippedBinary.permissions();
     executablePermissions |= QFileDevice::ExeOwner | QFileDevice::ExeUser;
@@ -283,7 +287,7 @@ void Updater::installOrRestartClicked(QAbstractButton* button, const QString& fi
 {
     Q_UNUSED(button)
 
-    // moc, when used with cmake on macos bugs out if the entire function declaration and definition is entirely
+    // moc, when used with cmake on macOS bugs out if the entire function declaration and definition is entirely
     // commented out so we leave a stub in
 #if !defined(Q_OS_MACOS)
 

src/updater.h

@@ -42,6 +42,7 @@ class Updater : public QObject
 public:
     Q_DISABLE_COPY(Updater)
     explicit Updater(QObject* parent = nullptr, QSettings* settings = nullptr);
+    virtual ~Updater();
     void checkUpdatesOnStart();
     void manuallyCheckUpdates();
     void showChangelog() const;