Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logging options do not save chosen format #1765

Closed
jmclicquennoi opened this issue Jun 12, 2018 · 3 comments
Closed

New logging options do not save chosen format #1765

jmclicquennoi opened this issue Jun 12, 2018 · 3 comments

Comments

@jmclicquennoi
Copy link

Brief summary of issue / Description of requested feature:

When using the new "Log options" in the General tab of the Profile preferences it no longer saves the options chosen for how and where to save files, and constantly reverts to "Named file (concatenate logs in one file)".

Steps to reproduce the issue / Reasons for adding feature:

  1. Load profile
  2. Alt+P to open options
  3. Change the "Log format" dropdown away from "Named file (concatenate logs in one file)" to, e.g. "yyyy-MM-ddTHH-mm-ss (e.g. 1970-01-01T00-00-00.html)"
  4. Save and close Mudlet
  5. Reopen Mudlet
  6. Load profile
  7. Alt+P to open options
  8. "Log format" dropdown has reverted back to "Named file (concatenate logs in one file)" (also, if logging is turned on, loading the profile will reveal it is logging to logfile.html instead of the chosen file again)

Error output / Expected result of feature

"Log format" should stay at whatever is selected, and not revert to "Named file (concatenate logs in one file)" constantly.

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Began in 3.10
Windows 10, reliably reproducible on my end
Ticking "Save log files in HTML format instead of plain text" does remain and work as expected

@SlySven
Copy link
Member

SlySven commented Jun 13, 2018

Ah, the "mLogFileNameFormat" setting (a QString) is never written out in the XMLexport class - I bet the PR that start the improvements to the log file naming and save system was started before the one that improved (and made into a background thread) the save process but was not pulled into the development branch until the latter was finished. So saving the setting got lost in the conflict resolution...!

@SlySven
Copy link
Member

SlySven commented Jun 13, 2018

... I'll roll a quick fix for this now. Marking as a medium bug because it is broken and needs fixing for the next minor release but it is not a fatal problem so not an urgent must fix immediate issue.

@SlySven SlySven self-assigned this Jun 13, 2018
@SlySven SlySven added this to the 3.11.0 milestone Jun 13, 2018
SlySven added a commit to SlySven/Mudlet that referenced this issue Jun 13, 2018
It seems a clash in including two PRs lost the bit of code that was in one
of them to save the settings, because the saving code was revised by the
other.

This should close issue Mudlet#1765 ...

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven added a commit that referenced this issue Jun 15, 2018
It seems a clash in including two PRs lost the bit of code that was in one
of them to save the settings, because the saving code was revised by the
other.

This should close issue #1765 ...

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@SlySven
Copy link
Member

SlySven commented Jun 15, 2018

Should be fixed now.

@SlySven SlySven closed this as completed Jun 15, 2018
@SlySven SlySven removed their assignment Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants