Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mudlet_main_512x512_6XS_icon.ico is not actually 512x512 #5027

Open
vadi2 opened this issue Mar 24, 2021 · 2 comments
Open

mudlet_main_512x512_6XS_icon.ico is not actually 512x512 #5027

vadi2 opened this issue Mar 24, 2021 · 2 comments
Labels
good first issue Hacktoberfest Code & win a T-shirt :)

Comments

@vadi2
Copy link
Member

vadi2 commented Mar 24, 2021

Brief summary of issue / Description of requested feature:

According to https://redketchup.io/icon-editor, the icon does not actually go up to 512x512:

image

Steps to reproduce the issue / Reasons for adding feature:

  1. A higher quality image will have Mudlet look more professional

Error output / Expected result of feature

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

@SlySven
Copy link
Member

SlySven commented Mar 29, 2021

The file is incorrectly named then. The file format only allows for the largest icon in the file to be a 256x256 .png format one (which is scaled as appropriate on Windoze Vista or later) - the remainder are smaller .bmps - the sample you screen shot above is showing the 16x16 .bmp so it is not surprising it looks so crap when it is blown up as it is in that!

BTW You @vadi2 added it in #401 .

@vadi2 vadi2 added the Hacktoberfest Code & win a T-shirt :) label Sep 25, 2021
@atari2600tim
Copy link
Contributor

I assume 6XS part of name was intended to mean six sizes. GIMP shows 5, and since I'm not super familiar with GIMP, I looked in hex editor at the appropriate offset and it too says 5 images are in that file.
image

In the Talk page on Wikipedia, someone is saying that you can have larger images in an ICO file by giving them a size of 265 in the directory entry and then having 512 in the header data for the image and XP will be fine with it.
I see on https://redketchup.io/icon-converter there is an online editor that includes 512 but there is a warning if you hover over the i after Icon Sizes.

I haven't seen anything documenting this being an officially supported thing, and if there were then someone would have thrown it into the Wikipedia page I'm sure.

Microsoft talking about Windows 11 says by providing a 256px icon, ensures Windows should only ever scale your icon down, never up.

So I think for 512 icon, you would want it to not be in the ICO file, and you would want it in .ICNS for Mac and PNG format for Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Hacktoberfest Code & win a T-shirt :)
Projects
None yet
Development

No branches or pull requests

4 participants