Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release 30) add application icon #401

Merged
merged 4 commits into from Mar 10, 2017

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Mar 5, 2017

Adds an application icon for Windows so it doesn't look like shit in the start menu.

Before:
workspace 1_033

After:
vachon running - oracle vm virtualbox_037

Generated with http://icoconvert.com, doubt it supports all of the Win10 features though
@vadi2 vadi2 added the 1 - Ready label Mar 5, 2017
@vadi2 vadi2 requested a review from SlySven March 5, 2017 16:07
@vadi2
Copy link
Member Author

vadi2 commented Mar 5, 2017

This one is ready for a review-review in case you feel burnt from last night @SlySven.

Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Qmake QMAKE_TARGET_COMPANY and QMAKE_TARGET_DESCRIPTION variables were introduced somewhere between Qt 5.3.2 and 5.5.1 you will need to include a version check before you introduce them otherwise I'd expect Travis CI to barf on Linux/Qmake for both Clang and GCC cases.

Also, Windows builds are the most likely (IMHO) to use Cmake rather than Qmake and you need to do the equivalent thing for that build system...!

@vadi2
Copy link
Member Author

vadi2 commented Mar 6, 2017

Those are windows-specific variables though and the Windows Mudlet is using Qt 5.6 - it won't be an issue (it's why Travis CI passed).

I'm going to update the description because it turned out to be too long for what Windows practically expects in its menus.

Forgot about CMake, will apply a similar fix there. Thanks for the catch.

@vadi2
Copy link
Member Author

vadi2 commented Mar 6, 2017

I added what I think will do the trick, but the cmake on windows build is broken - or at least I can't get it to work. It is broken in all sorts of ways and the closest I got it to working was using the CMake GUI + MinGW Makefiles to produce the following:

The C compiler identification is GNU 4.8.1
The CXX compiler identification is GNU 4.8.1
Check for working C compiler: C:/mingw32/bin/gcc.exe
Check for working C compiler: C:/mingw32/bin/gcc.exe -- works
Detecting C compiler ABI info
Detecting C compiler ABI info - done
Check for working CXX compiler: C:/mingw32/bin/g++.exe
Check for working CXX compiler: C:/mingw32/bin/g++.exe -- works
Detecting CXX compiler ABI info
Detecting CXX compiler ABI info - done
CMake Error at C:/Program Files (x86)/CMake/share/cmake-3.0/Modules/FindPackageHandleStandardArgs.cmake:136 (message):
  Could NOT find ZIP (missing: ZIP_INCLUDE_DIR)
Call Stack (most recent call first):
  C:/Program Files (x86)/CMake/share/cmake-3.0/Modules/FindPackageHandleStandardArgs.cmake:343 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindZIP.cmake:77 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  src/CMakeLists.txt:363 (FIND_PACKAGE)


Configuring incomplete, errors occurred!
See also "C:/Users/Vadim.FURORENT/Desktop/New folder/CMakeFiles/CMakeOutput.log".

Fixing the cmake build on Windows isn't in scope of this PR, but I've filed an issue so we don't forget about it.

cmake hasn't been used to make Windows builds by the way, see compilation instructions - it's all good old g++.

@vadi2 vadi2 merged commit fe2eb36 into Mudlet:release_30 Mar 10, 2017
@vadi2 vadi2 deleted the (release_30)-add-application-icon branch March 13, 2017 05:54
mehulmathur16 pushed a commit to mehulmathur16/Mudlet that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants