New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(release 30) add application icon #401
(release 30) add application icon #401
Conversation
Generated with http://icoconvert.com, doubt it supports all of the Win10 features though
This one is ready for a review-review in case you feel burnt from last night @SlySven. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Qmake QMAKE_TARGET_COMPANY and QMAKE_TARGET_DESCRIPTION variables were introduced somewhere between Qt 5.3.2 and 5.5.1 you will need to include a version check before you introduce them otherwise I'd expect Travis CI to barf on Linux/Qmake for both Clang and GCC cases.
Also, Windows builds are the most likely (IMHO) to use Cmake rather than Qmake and you need to do the equivalent thing for that build system...!
Those are windows-specific variables though and the Windows Mudlet is using Qt 5.6 - it won't be an issue (it's why Travis CI passed). I'm going to update the description because it turned out to be too long for what Windows practically expects in its menus. Forgot about CMake, will apply a similar fix there. Thanks for the catch. |
It was so long it was overflowing crash dialogs.
I added what I think will do the trick, but the cmake on windows build is broken - or at least I can't get it to work. It is broken in all sorts of ways and the closest I got it to working was using the CMake GUI + MinGW Makefiles to produce the following:
Fixing the cmake build on Windows isn't in scope of this PR, but I've filed an issue so we don't forget about it. cmake hasn't been used to make Windows builds by the way, see compilation instructions - it's all good old g++. |
Adds an application icon for Windows so it doesn't look like shit in the start menu.
Before:
After: