-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 regression: search field no longer stays visible #508
Comments
Humm, I remember this, commit-10649019416655df3e6499d83862b09e88f803ed {2016-02-18 19:34:01} The QWidget then called "mpSearchArea" (but renamed there to widget_searchArea") was defined in the trigger_editor.ui file and was the container for all the search stuff, including the QComboBox that was the place to enter search terms, but in the dlgTriggerEditor constructor the value the pointer mpSearchArea pointed to was assigned a DIFFERENT widget namely the QTreeWidget tree_widget_search_results_main even though it seemed to be the "handle" for the whole of the search area. This didn't make sense to me. I found the control labelled button_searchAreaClose and having a "close" style icon had it's clicked signal (it not being a "Checkable" button, clicked() would be sent on every activation) wired to a slot that toggled the state of the search area (as well as the big "Search" button) - for that to make sense it seemed to me that the "close" button would be expected to hide itself when clicked. Together these gave me the impression that it was intended that clicking the "Search" button would show/hide the entire search area and that the "close" button would hide it. This was not happening as after the Search Area was brought up by the "Search" button the Search term entry box would not then go away! Remember that the same "close" button icon also is used on the system message area on the top right of the editor and in that location it causes the system message area to hide itself completely. It was my belief that I was fixing a bug when I recoded the behaviour to completely hide the search area. Given that it is reported that some users want something other that want is currently the case it is feasible to add a second button perhaps called "button_searchAreaResultsHide" underneath the first which can clear/hide the results part of the search area i.e. that part with the identifier "treeWidget_searchResults" - I can visualise the sort of code to do this in an additional SLOT method to the dlgTrigggerEditor class. Launchpad Details: #LPC Stephen Lyons - 2017-03-25 21:55:28 +0000 |
Okay, we misused an icon, but as far as the users are concerned, the functionality before worked OK, the functionality before does not work OK. Let's replace it with one of those expand/collapse icons then, but the feedback is clear, the old behaviour needs to come back. There's no real reason to use up more real estate either by adding an option to completely close it - completely closing it was not a feature that was requested. Launchpad Details: #LPC Vadim Peretokin - 2017-03-26 05:49:10 +0000 |
There were two ways to understand the situation - it was either a bug or a misused icon - in this case it was the latter, let's bring the behaviour back and change the button's icon. Launchpad Details: #LPC Vadim Peretokin - 2017-03-26 05:50:24 +0000 |
I have a PR to push out against the release_30 branch that does this but am not yet sure whether that is the place to request a pull against... Launchpad Details: #LPC Stephen Lyons - 2017-03-26 11:56:59 +0000 |
I'm not sure either. I was hoping to freeze release_30 so we can merge and On Sun, Mar 26, 2017 at 2:05 PM Stephen Lyons I have a PR to push out against the release_30 branch that does this but -- Title: To manage notifications about this bug go to: Launchpad Details: #LPC Vadim Peretokin - 2017-03-26 12:13:07 +0000 |
Yes, let's put it into release_30 and then update development_merge_30 with it too: #1 feedback in some discussions on 3.0 is this change in behaviour Vadi - Yesterday at 4:02 PM Launchpad Details: #LPC Vadim Peretokin - 2017-03-31 08:17:37 +0000 |
This is being looked at in PR #825... |
Solved as part of the above-mentioned PR. |
Check the return value in more places, and handle errors better. Also, explicitly null-terminate in more places as some implementations might not be well behaved.
Search button no longer toggles search to show the results panel or not - instead it toggles search showing up itself or not. This is a regression since search didn't take up that much space before in the collapsed view and there's demand for the old behaviour (http://forums.achaea.com/discussion/comment/356337/#Comment_356337)
Launchpad Details: #LP1675988 Vadim Peretokin - 2017-03-25 05:33:45 +0000
The text was updated successfully, but these errors were encountered: