Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to use onVisionFail in generic mapper #5455

Closed
vadi2 opened this issue Sep 25, 2021 · 12 comments · Fixed by #6915
Closed

Document how to use onVisionFail in generic mapper #5455

vadi2 opened this issue Sep 25, 2021 · 12 comments · Fixed by #6915
Labels
💎 Bounty bounty-20 see https://wiki.mudlet.org/w/Bounty_Process bounty-paid This bounty has been completed & paid out good first issue Lua only Issues with this label can be fixed by solely modifying lua code needs documentation This pull request changes things the players would use/see and thus needs an update in the manual 💰 Rewarded

Comments

@vadi2
Copy link
Member

vadi2 commented Sep 25, 2021 •
edited

Brief summary of issue / Description of requested feature:

Document how to use onVisionFail from generic mapper in the technical manual online, so people can discover how to use that functionality.

Code for onVisionFail can be found in the generic mapper script itself.
@vadi2 vadi2 added the needs documentation This pull request changes things the players would use/see and thus needs an update in the manual label Sep 25, 2021
@vadi2
Copy link
Member Author

vadi2 commented Sep 10, 2022 •
edited

In generic mapper itself as well (ie map help)

@vadi2 vadi2 added the Lua only Issues with this label can be fixed by solely modifying lua code label Sep 10, 2022
@Kebap Kebap added the bounty-20 see https://wiki.mudlet.org/w/Bounty_Process label Feb 17, 2023
@Kebap Kebap mentioned this issue Mar 17, 2023
Open
@vadi2
Copy link
Member Author

vadi2 commented May 11, 2023

/bounty $20

@algora-pbc
Copy link

algora-pbc bot commented May 11, 2023 •
edited

💎 $20 bounty created by vadi2
🙋 If you start working on this, comment /attempt #5455 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #5455 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to Mudlet/Mudlet!

Attempt Started Solution
🟢 @ZookaOnGit Jun 18, 2023 #6900

@ZookaOnGit
Copy link
Contributor

ZookaOnGit commented Jun 18, 2023 •
edited

/attempt #5455

Awaiting wiki user confirmation.

@demonnic
Copy link
Member

User confirmed.

@ZookaOnGit ZookaOnGit mentioned this issue Jun 22, 2023
Closed
@algora-pbc
Copy link

algora-pbc bot commented Jun 22, 2023 •
edited

💡 @ZookaOnGit submitted a pull request that claims the bounty. You can visit your org dashboard to reward.
👉 @ZookaOnGit: To receive payouts, sign up on Algora, link your Github account and connect with Stripe on your dashboard.

@ZookaOnGit
Copy link
Contributor

My first github commit : ) Happy to receive any feedback on workflow, expectations etc..

@vadi2
Copy link
Member Author

vadi2 commented Jun 29, 2023

@ZookaOnGit could you open a new PR with the improvements you've made to the generic mapper? Since that work is done now, we can pay it out :)

ZookaOnGit added a commit to ZookaOnGit/Mudlet that referenced this issue Jul 3, 2023
@ZookaOnGit
Update generic_mapper.xml help file to elaborate on onVision event.
dd0d784 
Update map help onvisionfail.
Fixes Mudlet#5455
@ZookaOnGit ZookaOnGit mentioned this issue Jul 3, 2023
Merged
@algora-pbc
Copy link

algora-pbc bot commented Jul 3, 2023

💡 @ZookaOnGit submitted a pull request that claims the bounty. You can visit your org dashboard to reward.
👉 @ZookaOnGit: To receive payouts, sign up on Algora, link your Github account and connect with Stripe on your dashboard.

1 similar comment
@algora-pbc
Copy link

algora-pbc bot commented Jul 3, 2023

💡 @ZookaOnGit submitted a pull request that claims the bounty. You can visit your org dashboard to reward.
👉 @ZookaOnGit: To receive payouts, sign up on Algora, link your Github account and connect with Stripe on your dashboard.

vadi2 pushed a commit that referenced this issue Jul 6, 2023
@ZookaOnGit
Improve: Update generic_mapper.xml help to elaborate on onVision even…
5a813c1 
…t. (#6915)

#### Brief overview of PR changes/additions
Update map help onvisionfail.
Fixes #5455

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->


#### Motivation for adding to Mudlet

/claim #5455

#### Other info (issues closed, discussion etc)
@vadi2
Copy link
Member Author

vadi2 commented Jul 6, 2023

Done! you should have the pay out @ZookaOnGit :)

@algora-pbc
Copy link

algora-pbc bot commented Jul 6, 2023

🎉🎈 @ZookaOnGit has been awarded $20! 🎈🎊

vadi2 pushed a commit to vadi2/Mudlet that referenced this issue Dec 24, 2023
@ZookaOnGit @vadi2
Improve: Update generic_mapper.xml help to elaborate on onVision even…
8d4dd5f 
…t. (Mudlet#6915)

#### Brief overview of PR changes/additions
Update map help onvisionfail.
Fixes Mudlet#5455

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->


#### Motivation for adding to Mudlet

/claim Mudlet#5455

#### Other info (issues closed, discussion etc)
@Kebap Kebap added the bounty-paid This bounty has been completed & paid out label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty bounty-20 see https://wiki.mudlet.org/w/Bounty_Process bounty-paid This bounty has been completed & paid out good first issue Lua only Issues with this label can be fixed by solely modifying lua code needs documentation This pull request changes things the players would use/see and thus needs an update in the manual 💰 Rewarded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve: Update generic_mapper.xml help to elaborate on onVision event. ZookaOnGit/Mudlet
4 participants
@demonnic @vadi2 @Kebap @ZookaOnGit