Room.Info appears to be manipulated by GMCP generic mapper before being put into a table

[gesslar]

Brief summary of issue / Description of requested feature:

1. When I send a GMCP message to Mudlet for Room.Info, I am sending the exits mapping as string : string, however, it appears in the Mudlet table as string : number
2. When I sent anything that doesn't equate to a number, it doesn't appear at all.

In the first case, I would expect it to be a string, since that is what is being sent.

The second case prohibits using alternative means of identifying rooms. In muds that don't have a vnum system, it would be helpful for other ways to identify rooms, such as perhaps a base64-encoded string that represents the file name of the room one is in.

Steps to reproduce the issue / Reasons for adding feature:

1. Send Room.Info { "name" : "Some Room", "exits" : { "east" : "100" } }
2. Send Room.Info { "name" : "Some Room", "exits" : { "east" : "L2QvdGhyYWNlL3RocmFjZS9ub3J0aDI=" } }

Error output / Expected result of feature

1. Transforms to a number

Room = {
    Info = {
        name = "Some Room",
        exits = {
            "east" : 100
        }
    }
}

2. Omits the exits

Room = {
    Info = {
        name = "Some Room",
        exits = {}
    }
}

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

Mudlet 4.15.1, Windows 11

[SlySven]

Does that second example exactly reproduce what you are testing with - because "L2QvdGhyYWNlL3RocmFjZS9ub3J0aDI= does not end with a " so won't be a valid string value!

[gesslar]

Does that second example exactly reproduce what you are testing with - because "L2QvdGhyYWNlL3RocmFjZS9ub3J0aDI= does not end with a " so won't be a valid string value!

Corrected the typo, sorry about that!

[atari2600tim]

I opened up 2 tabs. 1 is fresh profile. 2 is remove generic mapper package, create script and paste in the code from the forum at https://forums.mudlet.org/viewtopic.php?p=46638#p46638 Then in each tab I sent myself that message and then that same message substituting an X in Info. They both show Infx good, but the one with the forum script shows the Info wrong. Without looking at the script too closely just yet, I'd say either the script chokes on it and interrupts Mudlet in setting it, or trashes it after Mudlet has set it.

Then I adjusted the code of that script to make it print the variable, added this display function...

function map.eventHandler(event,...)
    if event == "gmcp.Room.Info" then
        display(gmcp.Room.Info)

Now after doing that, it shows that it was valid at that point and then messed up after that specific spot but before I typed the lua command.

I'm not familiar enough with it to know if maybe there's a pass by reference issue or something like that.

[atari2600tim]

I guess it's this for loop.

        echo("DEBUG-b about to do loop\n") display(gmcp.Room.Info)
        for k,v in pairs(map.room_info.exits) do
            map.room_info.exits[k] = tonumber(v)
        end
        echo("DEBUG-c about to do handle_move\n") display(gmcp.Room.Info)

Earlier in the code, I expect this part is making a pointer instead of copying data...

        map.room_info = {
          vnum = tonumber(gmcp.Room.Info.num),
          area = gmcp.Room.Info.area,
          name = gmcp.Room.Info.name,
          terrain = gmcp.Room.Info.environment,
          exits = gmcp.Room.Info.exits
        }

[vadi2]

Ahh yep. Add a table.deepcopy() in there, does that fix it?

[vadi2]

Issue is with a 3rd party script, posted the solution to https://forums.mudlet.org/viewtopic.php?f=13&t=23065&p=46822#p46822