New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: save & load custom line colors in map format version less than 20 #2559
BugFix: save & load custom line colors in map format version less than 20 #2559
Conversation
…an 20 This will close Mudlet#2558 . The bug was made in Mudlet#2106 which has been present since before Mudlet 2.16.0 was released· Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Hey there! Thanks for helping Mudlet improve. 🌟 You can directly test the changes here:
No need to install anything - just unzip and run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to check here for UI purposes.
The code changes look sensible as well.
Oi @Kebap! This is my PR and my web-browser is set to spell checking in my language - you retitling it to Americanish seems a bit heavy handed... 😝 |
Although Mudlet#2559 fixed a problem with custom exit line colour handling, it did not do anything to fixup maps that were generated prior to that fix being inserted into the code-base. This PR does so by converting any missing or empty (no colour components) to have a default RED colour. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Although #2559 fixed a problem with custom exit line colour handling, it did not do anything to fixup maps that were generated prior to that fix being inserted into the code-base. This PR does so by converting any missing or empty (no colour components) to have a default RED colour. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This will close #2558 .
The bug was made in #2106 which has been present since before Mudlet 2.16.0 was released·
Signed-off-by: Stephen Lyons slysven@virginmedia.com