(release_30)Bugfix/Enhance: Suppress debug output from short interval timers #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a spinbox control to the last page of the profile preferences that allows the user to set an interval for which any Timer less than this will NOT dump it's command and script content to the debug console in dark yellow on a blue background EVERY time it fires. The Execute OK line will still show up in green - so the timer can be seen to be firing but the windows will not fill up with spammy text so much. Also: I also spotted and corrected a couple of lines above my addition to dlgProfilePreferences::slot_save_and_exit() where the unchecked global pointer to the Host (mpHost) was being used instead of the local checked pointer (pHost) which is a copy of it and used everywhere else in the method. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
changed the title
|
Is it acceptable to merge this one Vadim? |
|
+1 |
SlySven
added a commit
that referenced
this pull request
Oct 30, 2015
…ionOfShortIntervalTimerDebugOutput (release_30)Bugfix/Enhance: Suppress debug output from short interval timers
SlySven
deleted the
(release_30)enhance_allowSupressionOfShortIntervalTimerDebugOutput
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a spinbox control to the last page of the profile preferences that
allows the user to set an interval for which any Timer less than this will
NOT dump it's command and script content to the debug console in dark
yellow on a blue background EVERY time it fires. The Execute OK line will
still show up in green - so the timer can be seen to be firing but the
windows will not fill up with spammy text so much.
This fixes bug 1511590 that I have raised in response to my encountering it
and remembering a user reporting it in the forums.
Also: I also spotted and corrected a couple of lines above my addition to
dlgProfilePreferences::slot_save_and_exit() where the unchecked global
pointer to the Host (mpHost) was being used instead of the local checked
pointer (pHost) which is a copy of it and used everywhere else in the
method.
See #275 for development branch version
Signed-off-by: Stephen Lyons slysven@virginmedia.com