Crius mac oldenly patch 1

[CriusMacOldenly]

Brief overview of PR changes/additions

Fix for Scrollbar does not move with mousewheel/pg scrolling #612

Motivation for adding to Mudlet

I was scrolling with the mouse wheel, and was greatly bothered when I clicked on the scroll bar and it reset the scroll position as if I had never used the mouse wheel to scroll at all.

Other info (issues closed, discussion etc)

This change has my previous changes because this seems to be a patch, with no ability to do my own new fork/pull request, and it was much easier to fix this bug than figure out what github wanted.

[add-deployment-links]

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

• linux: https://make.mudlet.org/snapshots/000d4b/Mudlet-4.1.2-testing-PR3186-271f2d9-linux-x64.AppImage.tar
• osx: https://make.mudlet.org/snapshots/589f3a/Mudlet-4.1.2-testing-PR3186-271f2d9.dmg
• windows: https://make.mudlet.org/snapshots/161091/Mudlet-4.1.2-testing-PR3186-271f2d91-windows.zip

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

[vadi2]

Could you please fill in the title and description for this PR?

[Kebap]

Could you please fill in the title and description for this PR?

There is some information in the original issue here: #612 (comment)

I have issued a fix for this problem in #3186 .
The entire changes for this fix are the differences between the original text selection patch, and patch 1.
If you don't want the #612 fix, don't use patch 1. If you do want the #612 fix, you can merge it in without the text selection fix which is the original patch. I'm certain the change is small enough that you can see the changes between the text selection fix and the scrollbar fix.

[Kebap]

This PR seems somewhat strange.
You have included all changes from your "development" branch, that is #3166, into this branch here as well. This is not very helpful.
Instead, the changes you intended for #612 should come without the rest of the changes before.
Please let me know if you need additional support here.

Also, your last commit (the only relevant here) seems to add a new file in the root folder, and not modify the existing file in src/ directory.
Please review and adjust accordingly.

Thanks for looking into this!

[vadi2]

We covered this in Discord today - @CriusMacOldenly is super new to Git and they wanted to include changes from the other PR in this one, so we'll go easy :)

[Kebap]

Did you also discuss the new/updated file issue?

[vadi2]

Yeah... enough pain from git for @CriusMacOldenly for today I think, I'll sort this out 😅

[SlySven]

Also - your Git (or your code editor) is incorrectly set up as it is putting in carriage-returns as well as line-feeds (Window style End-Of-Lines) at the end of each line instead of the standard which we used which is just line-feeds (*nix style End-Of-Lines). Which ballses things up for doing diffs on the files to extract the changes...

[CriusMacOldenly]

You guys insisted I use QT Creator, which I did.
https://stackoverflow.com/questions/9895865/how-to-set-crlf-endings-in-qtcreator-on-linux
https://forum.qt.io/topic/3521/is-there-a-way-to-instruct-the-qt-creator-to-save-a-file-with-linux-line-endings-on-windows

[SlySven]

I am just putting together a PR against your proposal that should clean things up here... wait a few minutes please...

[CriusMacOldenly]

I made certain a checkmark was placed in:
Allow edits from maintainers.
It shouldn't be too bad really. I have no plans to do any other coding on mudlet at this time, so any changes you make will survive the test of time.

[SlySven]

Okay can you go to https://github.com/CriusMacOldenly/Mudlet/pull/1 ... and follow the instruction I have offered...

[SlySven]

Success! Now the "Files changed" tab at the top of the page shows the actual changes you want to make...

[CriusMacOldenly]

Indeed. I can now see 6 lines I commented out, but forgot to delete. :( Should have only been +92 -198 in the end. I'd edit the file again and remove them, but that'll probably bother you a lot.

[SlySven]

I've taken a quick look at this - and thought "this is not going to be a simple one to review" - I am sorry but apart from several good cups of coffee I think it is going to take a while for me to get back into gear over the code in this bit and I fear I will not be able to give a meaningful reply without some serious playing with it over the next few days. The good news is that I do have some time off for all of the next fortnight...

[SlySven]

Before pushing another change out to your github repository I wonder if there is a way to see whether there are CR-LF or just LF on the ends of the lines in the files that get changed. I note that it was only the TTextEdit.cpp file that got messed up, even though you had edited both it and the TTextEdit.h file... 🤔

[CriusMacOldenly]

You need to separate declaring y1 and assigning it because normalizeSelection() assigns mPA, which is then assigned to y1.
The header also had the incorrect line ends but Vadi modified both the h and cpp file's line endings, then I only altered the cpp afterwards... which left the h file still with the Vadi altered line endings.

[SlySven]

Humm, 🤔 so every file you touch gets converted to Windows style end-of-lines and committed as such.

If you go to the place in your file-system where the Mudlet source code is and type in a command line:

git config core.autocrlf

does it report anything?

[CriusMacOldenly]

D:\Mudlet>git config core.autocrlf
true

[CriusMacOldenly]

Any other changes before I commit your requested y1 declare and assign change?

[SlySven]

Please hold... you are in a queue and the next available operator will be with you as soon as possible... 🙂

[CriusMacOldenly]

Oh, I already committed the change you requested, and deleted the commented out lines like I wanted.
If there are more changes wanted, I'll just make them, and upload them again. It's all good.

[SlySven]

Your call is important to us, please hold and the next available operator will be with you as soon as they can - alternatively you might like to check out our on-line presence on the Interweb thingy...

I'm discussing the EOL issue on Discord - if you want to go to the #help channel mayhaps we can nail this problem there...

[CriusMacOldenly]

This patch introduces an issue of a quick flicker where the split pane appears and disappears when starting to scroll up with the mouse alone. Vadi linked a video in https://streamable.com/jycjg .