Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar fix #612 #3198

Closed
wants to merge 10 commits into from
Closed

Scrollbar fix #612 #3198

wants to merge 10 commits into from

Conversation

CriusMacOldenly
Copy link
Contributor

These changes fix issue #612 . They do introduce a flicker when scrolling up at this time.

Brief overview of PR changes/additions

Added 2 lines each to set the value of the scrollbar on bufferScrollDown() and bufferScrollUp().

Motivation for adding to Mudlet

I was bothered by the fact that when I used the mouse wheel to scroll up or down that the scrollbar didn't move. If I then clicked on the scrollbar, I was moved to a place as if I didn't use the mouse wheel at all. This also affects pg up and pg down not affecting the scrollbar.

Other info (issues closed, discussion etc)

This closes issue #612 , however, it causes a flicker of the split pane due to issue #3054 .

@CriusMacOldenly CriusMacOldenly requested review from a team as code owners October 26, 2019 19:11
@add-deployment-links
Copy link

add-deployment-links bot commented Oct 26, 2019

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2
Copy link
Member

vadi2 commented Dec 13, 2019

@CriusMacOldenly is this something you're interested in seeing through?

@CriusMacOldenly
Copy link
Contributor Author

As stated in the description:
This closes issue #612 , however, it causes a flicker of the split pane due to issue #3054 .
Since you did not find the scrollbar flicker acceptable, and I was unable to quickly fix issue #3054 , I permanently put this on hold (until someone could figure out #3054 ). Do you want this closed?

@vadi2
Copy link
Member

vadi2 commented Dec 13, 2019

Yes, until #3054 is addressed, it's best to do so.

@vadi2 vadi2 closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants