New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlyoutLabel fixes (layout, user experience) #3426
Conversation
Fixes some issues with flyoutLabels
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
…ole menu Made some changes that closeNest and Geyser.Label.currentLabel aren't now needed anymore leaving an menu will close the whole menu now as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! This all works great. :)
🚀
It works very well for #2000 ... @Edru2 ❤️❤️❤️❤️❤️❤️ I'd like to report another strange behaviur maybe related to #836:
I think that flyout should hide when I don't hover on them. It isn't a big problem, however. Your PR is just great as it is! |
I'm happy to help 😃
Yes, this is intended behavior. btw I think your post is referring to the wrong issue. |
It stays for a bit because if you accidentally move your mouse out, it dissapears right away - which is frustrating, your "work" is reset. So the idea is to have a slight delay to allow the person to move the mouse back in if they did it by accident. I hope that helps |
Ok, I understand. So thanks again @Edru2 for this PR! |
AWESOME, thank you @Edru2 |
* flyoutLabel fixes Fixes some issues with flyoutLabels * remove closeNest and Geyser.Label.currentLabel leaving menu closes whole menu Made some changes that closeNest and Geyser.Label.currentLabel aren't now needed anymore leaving an menu will close the whole menu now as expected
Brief overview of PR changes/additions
Rewrite and simplification of some flyoutLabel Code
and
Fix of several flyoutLabel issues
Motivation for adding to Mudlet
Fixes the issues:
#837
#836
#2500
Other info (issues closed, discussion etc)
Also contains the changes made in #3394
Wanted to PR soon to let people test this also in UserWindows