Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlyoutLabel fixes (layout, user experience) #3426

Merged
merged 2 commits into from
Mar 13, 2020
Merged

FlyoutLabel fixes (layout, user experience) #3426

merged 2 commits into from
Mar 13, 2020

Conversation

Edru2
Copy link
Member

@Edru2 Edru2 commented Mar 12, 2020

Brief overview of PR changes/additions

Rewrite and simplification of some flyoutLabel Code
and
Fix of several flyoutLabel issues

Motivation for adding to Mudlet

Fixes the issues:
#837
#836
#2500

Other info (issues closed, discussion etc)

Also contains the changes made in #3394
Wanted to PR soon to let people test this also in UserWindows

@Edru2
flyoutLabel fixes
1200f1a 
Fixes some issues with flyoutLabels
@Edru2 Edru2 requested a review from a team as a code owner March 12, 2020 17:44
@add-deployment-links
Copy link

add-deployment-links bot commented Mar 12, 2020 •
edited

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@Edru2
remove closeNest and Geyser.Label.currentLabel leaving menu closes wh…
dfc363c 
…ole menu

Made some changes that closeNest and Geyser.Label.currentLabel aren't now needed anymore
leaving an menu will close the whole menu now as expected
@vadi2 vadi2 changed the title flyoutLabel fixes FlyoutLabel fixes (layout, user experience) Mar 13, 2020
vadi2
vadi2 approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! This all works great. :)

🚀

@vadi2 vadi2 merged commit 8e34200 into Mudlet:development Mar 13, 2020
@vadi2 vadi2 mentioned this pull request Mar 13, 2020
Closed
@Edru2 Edru2 mentioned this pull request Mar 17, 2020
Closed
@wiploo
Copy link
Contributor

wiploo commented Mar 17, 2020

It works very well for #2000 ... @Edru2 ❤️❤️❤️❤️❤️❤️

I'd like to report another strange behaviur maybe related to #836:

  • I open a flyout menu (clicking on its main parent)
  • I click on prompt or on menù or in any point of mudlet
  • flyout menu keep open, but after few second disappear

I think that flyout should hide when I don't hover on them.

It isn't a big problem, however. Your PR is just great as it is!

@Edru2
Copy link
Member Author

Edru2 commented Mar 17, 2020

I'm happy to help 😃

I'd like to report another strange behaviur maybe related to #836:
I open a flyout menu (clicking on its main parent)
I click on prompt or on menù or in any point of mudlet
flyout menu keep open, but after few second disappear

Yes, this is intended behavior.
You can make it disappear instantly if you click on the main menu again.

btw I think your post is referring to the wrong issue.

@vadi2
Copy link
Member

vadi2 commented Mar 17, 2020

It stays for a bit because if you accidentally move your mouse out, it dissapears right away - which is frustrating, your "work" is reset. So the idea is to have a slight delay to allow the person to move the mouse back in if they did it by accident. I hope that helps

@wiploo
Copy link
Contributor

wiploo commented Mar 17, 2020

Ok, I understand. So thanks again @Edru2 for this PR!

@Jieiku
Copy link
Contributor

Jieiku commented Sep 23, 2020

AWESOME, thank you @Edru2

Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
@Edru2 @Chris7
FlyoutLabel fixes (layout, user experience) (Mudlet#3426)
67a51e9 
* flyoutLabel fixes

Fixes some issues with flyoutLabels

* remove closeNest and Geyser.Label.currentLabel leaving menu closes whole menu

Made some changes that closeNest and Geyser.Label.currentLabel aren't now needed anymore
leaving an menu will close the whole menu now as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadi2 vadi2 vadi2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Edru2 @wiploo @vadi2 @Jieiku