(release 30) update default scripts (IRE, 3k mappers) #400

vadi2 · 2017-03-04T13:04:23Z

Updated scripts included with Mudlet to their latest versions from original source repositories.

Commit db579ba5595577a63875132609f0bdb279d61878 from https://github.com/Chris7/3k-Scripts

Taken from http://forums.mudlet.org/viewtopic.php?f=7&t=2325

Commit 3b047fa18e4d91135d04aa97ede1dd85250e1df8 from https://github.com/IRE-Mudlet-Mapping/ire-mapping-script

vadi2 · 2017-03-04T13:05:04Z

@keneanung this'll bring up mudlet-mapper script from the version 5 years ago to latest as well.

SlySven · 2017-03-04T20:05:36Z

src/3k-mapper.xml

@@ -228,17 +229,19 @@ send(&quot;look&quot;)</script>
                    <colorTriggerFgColor>#000000</colorTriggerFgColor>
                    <colorTriggerBgColor>#000000</colorTriggerBgColor>
                    <regexCodeList>
-                        <string>You cannot go</string>
+                        <string>You cannot go (west|east|south|north|up|down|northeast|northwest|southwest|southeast).$</string>
+                        <string>You cannot get it up.$</string>


That is, perhaps, an unfortunate phrase. 🤣

SlySven · 2017-03-04T20:09:19Z

src/3k-mapper.xml

                    </regexCodePropertyList>
                </Trigger>
                <Trigger isActive="yes" isFolder="no" isTempTrigger="no" isMultiline="no" isPerlSlashGOption="no" isColorizerTrigger="no" isFilterTrigger="no" isSoundTrigger="no" isColorTrigger="no" isColorTriggerFg="no" isColorTriggerBg="no">
                    <name>Too dark</name>
                    <script>tmap.roomEntered = true
 if tmap:mapon() then
-	tmap:echo(&quot;TURN ON A LIGHT!!!!!!!!&quot;)
+	tmap:echo(&quot;\nMAPPING IN THE DARK.  TURN ON A LIGHT!!!!!!!!\n&quot;)


Perhaps:
tmap:echo("\nYou can't see anything, yet you want to go MAPPING IN THE DARK? TURN ON A LIGHT!!!!!!!!\n") 😆

This is just a third-party that we include in Mudlet, won't be doing any modifications to it. Source is at https://github.com/Chris7/3k-Scripts if you're keen.

SlySven · 2017-03-04T20:17:14Z

src/3k-mapper.xml

@@ -438,8 +443,12 @@ end</script>
                <Alias isActive="yes" isFolder="no">
                    <name>Show Exits</name>
                    <script>--show room exits
-tmap:echo(getRoomExits(tmap.lastId))
-tmap:echo(&quot;special exits:\n&quot;)
+local exits = getRoomExits(tmap.lastId)


getRoomExits( roomId ) returns nothing if the room does not exist - so that means exits will be nil in that case. Do you need to have a check for that?

SlySven · 2017-03-04T20:18:37Z

src/3k-mapper.xml

+for k,v in pairs(exits) do
+  echo(&quot;   &quot; .. k .. &quot; -&gt; &quot; .. v .. &quot;\n&quot;)
+end
+tmap:echo(&quot;Special Exits:\n&quot;)
 tmap:echo(getSpecialExitsSwap(tmap.lastId))</script>


As above, getSpecialExitsSwap( roomId ) also returns nil on invalid roomId...

Oy... all issues to file at https://github.com/Chris7/3k-Scripts if you'd like. I didn't write this script, just updating it to latest, we're already shipping it with Mudlet!

SlySven · 2017-03-04T20:23:30Z

src/3k-mapper.xml

+                    <script>--renames current area
+local Name = matches[2]
+local cArea = getRoomArea(tmap.lastId)
+setAreaName( cArea, Name )</script>


With the enforced uniqueness of area names, setAreaName( oldArea, newArea ) now accepts an existing area name as a string for oldArea BTW...

SlySven · 2017-03-04T20:26:24Z

src/3k-mapper.xml

+                    <script>local aid = getRoomArea(tmap.lastId)
+local rooms = getAreaRooms(aid)
+for i,v in pairs(rooms) do
+	local stubs = getExitStubs(v)


getExitStubs( roomId ) starts its listing with a 0 - but there is now getExitStubs1( roomId ) which does the correct thing for a lua table and starts at 1 for the first entry.

It returns a list of numbers corresponding to the exit direction codes (1 to 12).

SlySven · 2017-03-04T20:37:49Z

src/3k-mapper.xml

+	local stubs = getExitStubs(v)
+	if stubs and type(stubs) == 'table' then
+		for j,k in pairs(stubs) do
+			connectExitStub(v,k)


As I note in comment 6 bug 1114594 this only works where the first argument is the fromRoomId and the second argument is a direction code (1 to 12) or a specific exit command string. In this case it IS so WILL work. 😌

SlySven · 2017-03-04T20:48:12Z

src/3k-mapper.xml

+                    <script>if not matches[2] then
+	tmap:echo(&quot;Syntax: tmap deleteArea area name&quot;)
+else
+	local atable = getAreaTableSwap()


TLuaInterpreter::deleteArea(...) is now fully working and will take an existing area name as a string to delete. The code here is, I think, redundant.

🪲 However, there is a nasty corner case in that deleteArea(...) called with the same string as TRoomDB::mDefaultAreaName may delete the -1 area (I'll have to check more deeply), which does not sound good! 😱

SlySven · 2017-03-04T21:10:55Z

src/3k-mapper.xml

+	elseif needed == &quot;number&quot; then
+		return tonumber(val)
+	elseif needed == &quot;string&quot; then
+		return 


Is there something missing here? 😕

SlySven · 2017-03-04T21:13:30Z

src/3k-mapper.xml

  tmap:echo(string.format(&quot;Created new label #%d '%s' in %s.&quot;, lid, message, getRoomAreaName(getRoomArea(room))))
  local labels = getRoomUserData(room, &quot;mapLabels&quot;)
  local labelRep = tostring(getRoomArea(room))..'.'..tostring(lid)
  --labels is structured like: dir|||id|||label|||x,y,z offset|||fg|||bg!&amp;!dir2|||id|||label|||xyz...
 --  local lTable = string.split(labels,'!&amp;!')
-  if labels ~= &quot;&quot; then
+   if labels ~= &quot;&quot; then


SlySven · 2017-03-04T21:19:29Z

src/mudlet-mapper.xml

                        </regexCodePropertyList>
                    </Trigger>
                    <Trigger isActive="yes" isFolder="no" isTempTrigger="no" isMultiline="no" isPerlSlashGOption="no" isColorizerTrigger="no" isFilterTrigger="no" isSoundTrigger="no" isColorTrigger="no" isColorTriggerFg="no" isColorTriggerBg="no">
-                        <name>Stop (angel presences</name>
-                        <script>setTriggerStayOpen(&quot;Angel presences&quot;, 0)
+                        <name>Stop (angel presences)</name>


Maybe should be <name>Stop (angel/demon) presences</name>?

SlySven · 2017-03-04T21:27:39Z

src/mudlet-mapper.xml

+
+if not statusnum then mmp.echo(&quot;Unrecognized option - a door can be open, closed, locked or gone.&quot;) return end
+
+setDoor(room, direction, statusnum)


Now returns true if a change was effected, false if there was no actual change (but the command was valid e.g. setting an open door when there was already a door of that type set) or nil + error message if there is a problem...! This could make the following message only report if a change was made.

SlySven · 2017-03-04T21:38:25Z

src/mudlet-mapper.xml

@@ -3186,58 +3769,131 @@ end

 if not area then mmp.echo(matches[3]..&quot; isn't a known area. Which one do you want to set?&quot;) return end

-local tmp = getRoomUserData(1, &quot;areaContinents&quot;)


I see that data is not now being stored in roomId 1 at least here, has it moved to map or area userdata yet - or will it wait until we actually get to Release 3.0 (where we will update the default map format to a higher value that supports them)?

Given how the script works to ensure maximum compatibility with most versions of Mudlet, using map userdata won't happen that soon.

SlySven · 2017-03-04T21:47:08Z

src/mudlet-mapper.xml

+
+local from, to = tonumber(matches[2]), tonumber(matches[3])
+
+getPath(from, to)


Don't forget you now have the global speedWalkWeight table as well now with the weights of each step and the getPath() function also has a return value of the total weight of the route. 😃

This isn't documented on the Mudlet wiki - will add documentation.

Done http://wiki.mudlet.org/w/Manual:Mapper_Functions#getPath

SlySven · 2017-03-04T21:50:22Z

src/mudlet-mapper.xml

@@ -3549,6 +4231,112 @@ end</script>
                <packageName></packageName>
                <regex>^room marks$</regex>


Um, I am giving up on looking through this, just too much to digest, I hope it all works, please indicate whether you'd prefer me to keep going... 😞

SlySven · 2017-03-04T21:54:13Z

@vadi2 Didn't catch your indication that this is really held over on @Chris7's repository until I returned to this page - so didn't stop commenting until I gave up! 😊

vadi2 · 2017-03-05T03:32:59Z

Yup... Noticed. Mind approving? This is blanket one.

…

On Sat, 4 Mar 2017 10:54 pm Stephen Lyons, ***@***.***> wrote: @vadi2 <https://github.com/vadi2> Didn't catch your indication that this is really held over on @Chris7 <https://github.com/Chris7> repository until I gave up - so didn't stop commenting until I *gave up*! 😊 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#400 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGxjMkapukRmF-QMvn6pcIfMcIcCtcIks5rid2FgaJpZM4MTFJs> .

vadi2 · 2017-03-05T08:01:03Z

I've filed an issue at Chris7/3k-Scripts#7 to integrate your improvements. Sorry, tagging you for review was misleading - I just did that so you'd get a notification to approve the PR.

SlySven

Must remember to check for what happens for a deleteArea("Default Area") it might delete area -1 which could be bad.

vadi2 · 2017-03-05T21:45:29Z

OK, give it a look. Thanks!

vadi2 added 3 commits March 4, 2017 13:49

Updated 3k-mapper to latest

fef80fa

Commit db579ba5595577a63875132609f0bdb279d61878 from https://github.com/Chris7/3k-Scripts

Updated deleteOldProfiles to latest

a3af851

Taken from http://forums.mudlet.org/viewtopic.php?f=7&t=2325

Update to latest IRE Mudlet Mapper script

abeef04

Commit 3b047fa18e4d91135d04aa97ede1dd85250e1df8 from https://github.com/IRE-Mudlet-Mapping/ire-mapping-script

vadi2 requested a review from SlySven March 4, 2017 13:04

vadi2 added the 1 - Ready label Mar 4, 2017

SlySven reviewed Mar 4, 2017

View reviewed changes

vadi2 mentioned this pull request Mar 5, 2017

Mudlet 3.0 script improvements Chris7/3k-Scripts#7

Open

SlySven approved these changes Mar 5, 2017

View reviewed changes

vadi2 merged commit 0a263a1 into Mudlet:release_30 Mar 5, 2017

vadi2 deleted the (release_30)-update-default-scripts branch March 5, 2017 21:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(release 30) update default scripts (IRE, 3k mappers) #400

(release 30) update default scripts (IRE, 3k mappers) #400

vadi2 commented Mar 4, 2017

vadi2 commented Mar 4, 2017

SlySven Mar 4, 2017

SlySven Mar 4, 2017 •

edited

vadi2 Mar 4, 2017

SlySven Mar 4, 2017

SlySven Mar 4, 2017

vadi2 Mar 4, 2017

SlySven Mar 4, 2017

SlySven Mar 4, 2017 •

edited

SlySven Mar 4, 2017

SlySven Mar 4, 2017

SlySven Mar 4, 2017

SlySven Mar 4, 2017

SlySven Mar 4, 2017 •

edited

SlySven Mar 4, 2017 •

edited

SlySven Mar 4, 2017

vadi2 Mar 5, 2017

SlySven Mar 4, 2017

vadi2 Mar 5, 2017

vadi2 Mar 5, 2017

SlySven Mar 4, 2017

SlySven commented Mar 4, 2017 •

edited

vadi2 commented Mar 5, 2017 via email

vadi2 commented Mar 5, 2017

SlySven left a comment

vadi2 commented Mar 5, 2017


		if not statusnum then mmp.echo("Unrecognized option - a door can be open, closed, locked or gone.") return end

		setDoor(room, direction, statusnum)

		@@ -3186,58 +3769,131 @@ end

		if not area then mmp.echo(matches[3].." isn't a known area. Which one do you want to set?") return end

		local tmp = getRoomUserData(1, "areaContinents")


		local from, to = tonumber(matches[2]), tonumber(matches[3])

		getPath(from, to)

		@@ -3549,6 +4231,112 @@ end</script>
		<packageName></packageName>
		<regex>^room marks$</regex>

(release 30) update default scripts (IRE, 3k mappers) #400

(release 30) update default scripts (IRE, 3k mappers) #400

Conversation

vadi2 commented Mar 4, 2017

vadi2 commented Mar 4, 2017

Choose a reason for hiding this comment

SlySven Mar 4, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SlySven Mar 4, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SlySven Mar 4, 2017 • edited

Choose a reason for hiding this comment

SlySven Mar 4, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SlySven commented Mar 4, 2017 • edited

vadi2 commented Mar 5, 2017 via email

vadi2 commented Mar 5, 2017

SlySven left a comment

Choose a reason for hiding this comment

vadi2 commented Mar 5, 2017

SlySven Mar 4, 2017 •

edited

SlySven Mar 4, 2017 •

edited

SlySven Mar 4, 2017 •

edited

SlySven Mar 4, 2017 •

edited

SlySven commented Mar 4, 2017 •

edited