(dev) Fix setExitStub to allow in/out stubs #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See http://forums.mudlet.org/viewtopic.php?f=9&t=14770&p=34560#p34644 This actually reveals another bug; if you pass it 13 the error message will be "setExitStub: Need a dir number as 2nd argument" - which while being technically true as 13 is not a recognised dir number, it in reality pretty annoying to see because an unaware user might be thinking that they -are- passing in a dir number. That said, keeping scope of the PRs small for digestibility and don't want to do refactorings of functions before 3.0 final. See https://bugs.launchpad.net/mudlet/+bug/1670245 (cherry picked from commit cd8c258)
SlySven
requested changes
Mar 6, 2017
|
Done, please have a look. |
SlySven
approved these changes
Mar 6, 2017
|
Remind me to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://forums.mudlet.org/viewtopic.php?f=9&t=14770&p=34560#p34644
This actually reveals another bug; if you pass it 13 the error message will be "setExitStub: Need a dir number as 2nd argument" - which while being technically true as 13 is not a recognised dir number, it in reality pretty annoying to see because an unaware user might be thinking that they -are- passing in a dir number. That said, keeping scope of the PRs small for digestibility and don't want to do refactorings of functions before 3.0 final. See https://bugs.launchpad.net/mudlet/+bug/1670245
(cherry picked from commit cd8c258)