Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Revert: restore compilation order on profile loading #417

Merged

Conversation

SlySven
Copy link
Member

@SlySven SlySven commented Mar 11, 2017

In commit a7f81aa (Pull Request #372) a change was made that reordered the compilation of the Lua scripts for Mudlet items. This commit reverts that aspect to restore the compilation of parent (e.g. folder/container) items before their children.

Signed-off-by: Stephen Lyons slysven@virginmedia.com

In commit-a7f81aafd9897cf38137f22638bfc3bca4d9f0d5 (Pull Request Mudlet#372) a
change was made that reordered the compilation of the Lua scripts for
Mudlet items.  This commit reverts that aspect to restore the compilation
of parent (e.g. folder/container) items before their children.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@vadi2
Copy link
Member

vadi2 commented Mar 11, 2017

Svof loads for me and that was one of the symptoms of the side-effect. Will see how #416 testing goes before confirming.

@vadi2
Copy link
Member

vadi2 commented Mar 12, 2017

See #416 .

@vadi2 vadi2 merged commit 74b3af8 into Mudlet:development Mar 12, 2017
@SlySven SlySven deleted the bugFix_restoreScriptCompilationOrder branch June 22, 2020 18:55
mehulmathur16 pushed a commit to mehulmathur16/Mudlet that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants