Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release_30) fix mccp toggling #425

Merged
merged 4 commits into from Mar 16, 2017

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Mar 14, 2017

Applies second patch from https://bugs.launchpad.net/mudlet/+bug/1119884.

Confirmed fixes test case for darklord.evils.in:9100 (create a character and type 'compress' to toggle MCCP on/off)

Confirmed fixes test case in http://www.mudbytes.net/forum/comment/72091/#c72091

Test case works on coffeemud.net port:2323 as well

@vadi2 vadi2 requested a review from SlySven March 14, 2017 04:20
@vadi2
Copy link
Member Author

vadi2 commented Mar 14, 2017

@SlySven all ready to be tested!

@vadi2 vadi2 changed the title (release 30) fix mccp toggling (release_30) fix mccp toggling Mar 14, 2017
@SlySven
Copy link
Member

SlySven commented Mar 15, 2017

See my comment on #424 ...

Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopting a suck it and see approach here!

7922a3a added getMudletLuaDefaultPath() that returned a single path, whereas the PR Mudlet#414 changed function to be getMudletLuaDefaultPaths() and made it return an indexed table. This fixes the wrong call that got left behind between cherrypicking and merging.
@vadi2 vadi2 merged commit 1324534 into Mudlet:release_30 Mar 16, 2017
@vadi2 vadi2 deleted the (release_30)-fix-mccp-toggling branch March 16, 2017 04:36
mehulmathur16 pushed a commit to mehulmathur16/Mudlet that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants