Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sparkle to latest release #4359

Merged
merged 3 commits into from Dec 14, 2020
Merged

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Nov 13, 2020

Brief overview of PR changes/additions

Update Sparkle to latest 1.24.

Motivation for adding to Mudlet

Good idea to stay on top of your dependencies.

Other info (issues closed, discussion etc)

See https://github.com/sparkle-project/Sparkle/releases for the changelog

@add-deployment-links
Copy link

add-deployment-links bot commented Nov 13, 2020

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2
Copy link
Member Author

vadi2 commented Nov 13, 2020

It seems to build okay, but I think Sparkle is actually excluded from the runtime because the whole .dmg isn't signed.

@vadi2 vadi2 marked this pull request as ready for review November 21, 2020 10:30
Copy link
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay give it a shot - assuming the rest still works... 🤷‍♂️

@vadi2 vadi2 merged commit 7e44188 into Mudlet:development Dec 14, 2020
@vadi2 vadi2 deleted the update-sparkle branch December 14, 2020 18:29
Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
* Update Sparkle

* Update Sparkle to latest 1.24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants