Improve: don't freeze Mudlet when copying large profile #5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
SlySven
reviewed
Mar 27, 2021
vadi2
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
SlySven
reviewed
Jan 3, 2022
|
What's with the "Check improvements with Mudlet's C++style guide / clang-tidy (pull_request_target)" failure - something is screwy with the update/ports of Hunspell - but just for that job...? 😵 |
|
Not sure. |
SlySven
reviewed
Apr 10, 2022
Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
reviewed
Apr 10, 2022
|
PR updated. |
SlySven
reviewed
Apr 18, 2022
| host_name_entry->setPalette(mErrorPalette); | ||
| validUrl = false; | ||
| valid = false; | ||
| } | ||
|
|
||
| if (url.indexOf(QRegularExpression(qsl("^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$")), 0) != -1) { |
There was a problem hiding this comment.
🤔 This is something for another PR but this won't handle IPv:six: addresses... issue raised as #6065.
SlySven
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Don't freeze Mudlet when copying large profile
Motivation for adding to Mudlet
Better user experience for long-time players with large profiles. It'll also help people not think Mudlet has crashed if it's been copying for too long.
Other info (issues closed, discussion etc)
Fix #1980, fix #487
Release post highlight
Improved: copying large profiles will no longer freeze Mudlet up.